[TC9 RC1] Wrong icon for .lnk files

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
yyang
Member
Member
Posts: 162
Joined: 2007-03-27, 11:41 UTC
Location: China

[TC9 RC1] Wrong icon for .lnk files

Post by *yyang »

Not sure if I missed anything new, but when I upgraded from 8.52a to 9 RC1, icons for all .lnk files went wrong. According to my backup files, this iconlib served well since (at least) 7.56a, and not a single update except this one broke it. My system is Windows 7 64-bit Simplified Chinese.

The icon for .lnk (both file and directory shortcuts) used to be at index 13 (http://www.ghisler.ch/wiki/index.php/Filelist_icons), showing a little arrow. Now it seems index 5 (standard files) is used, at any icon size, with both 32-bit and 64-bit versions.

I tried to modify the iconlib's index-5 icon to the arrow, expecting both .lnk and standard files should show arrows. The weird thing was:

- at 16x16 size, .lnk would still use the standard file icon (although 16x16 icons with proper colors were provided);
- at 24x24 size and above, .lnk would use the arrow icon;
- the preview window (in Configuration - Display - Icons - Icon size) would show the standard file icon at any size.

Using the built-in icons had the same effect.

I tried another laptop with a new Win 7 installation, and a new Windows XP virtual machine. In both cases, this wincmd.ini was used w/o custom iconlib:

[Configuration]
InstallDir=<mydir>

When Total Commander started, I set only 2 options in Configuration - Display - Icons, and accepted all defaults:

- Show icons - All associated checked.
- Show default folder/file icons from Explorer unchecked.

Result: Win7 still wrong (showing built-in standard file icon), XP good (showing built-in arrow icon).

This is another clueless moment for me. Any suggestion will be appreciated!
Last edited by yyang on 2016-10-14, 15:55 UTC, edited 1 time in total.
User avatar
sqa_wizard
Power Member
Power Member
Posts: 3896
Joined: 2003-02-06, 11:41 UTC
Location: Germany

Post by *sqa_wizard »

Just make sure you have overlays enabled.
Configuration - Options - Icons : "Show overlay icons e.g. for links"
#5767 Personal license
User avatar
petermad
Power Member
Power Member
Posts: 16115
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

2yyang
Also make sure that Configuration -> Icons -> "Show default folder/file icons from Explorer" is NOT selected, if you want to use an iconlib of your own.
License #524 (1994)
Danish Total Commander Translator
TC 11.55rc4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1393a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
yyang
Member
Member
Posts: 162
Joined: 2007-03-27, 11:41 UTC
Location: China

Post by *yyang »

sqa_wizard wrote:Just make sure you have overlays enabled.
Configuration - Options - Icons : "Show overlay icons e.g. for links"
Thanks! But I want the tiny arrow icon for .lnk files, not the overlay effect. Please see Paint.lnk in the 2nd figure of this page: http://www.ghisler.ch/wiki/index.php/Filelist_icons. It's exactly what the index-13 icon looks like in the "filelist icon library in detail" table.
petermad wrote:Also make sure that Configuration -> Icons -> "Show default folder/file icons from Explorer" is NOT selected, if you want to use an iconlib of your own.
Thank you, too. I can confirm this option is NOT selected.
Last edited by yyang on 2016-10-14, 15:54 UTC, edited 1 time in total.
User avatar
beb
Power Member
Power Member
Posts: 592
Joined: 2009-09-20, 08:03 UTC
Location: Odesa, Ukraine

Post by *beb »

yyang wrote:Please see Paint.lnk in the 2nd figure of this page:
Here is the correct link:
http://www.ghisler.ch/wiki/index.php/Filelist_icons.

(terminal dot has not to be included within link body part of bbcode url tag, as it has been formatted automatically by forum engine)
#278521 User License
Total Commander [always the latest version, including betas] x86/x64 on Win10 x64/Android 16
User avatar
yyang
Member
Member
Posts: 162
Joined: 2007-03-27, 11:41 UTC
Location: China

Post by *yyang »

beb wrote:
yyang wrote:Please see Paint.lnk in the 2nd figure of this page:
terminal dot has not to be included within link body part of bbcode url tag, as it has been formatted automatically by forum engine.
Edited. Thanks!
User avatar
petermad
Power Member
Power Member
Posts: 16115
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

2yyang

To get the arrows for LNK directories that you see in this screenshot, use the setting also shown in the screenshot:

http://madsenworld.dk/tcmd/linkarrows.png

If you still don't see it like that, then remove any IconLib=xxx line form your wincmd.ini file


In TC9 it is no longer possible to have the bare link icon shown for .lnk files, when choosing "All associated" or "Only standard icons" - now this setting results in a standard folder icon:

http://madsenworld.dk/tcmd/linkarrows2.png


In TC8 and earlier the arrow icon was shown when "All associated" or "Only standard icons" was chosen:

http://madsenworld.dk/tcmd/linkarrows8.png


I too would like to see the arrow icon used, when choosing "All associated" or "Only standard icons"
License #524 (1994)
Danish Total Commander Translator
TC 11.55rc4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1393a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
yyang
Member
Member
Posts: 162
Joined: 2007-03-27, 11:41 UTC
Location: China

Post by *yyang »

petermad wrote: In TC9 it is no longer possible to have the bare link icon shown for .lnk files, when choosing "All associated" or "Only standard icons" - now this setting results in a standard folder icon...

I too would like to see the arrow icon used, when choosing "All associated" or "Only standard icons"
Thank you very much for the clarification! This explains my myth. But is this documented behavior? I have a quick search in HISTORY.txt for "icon" (and "XP" as well, explained below), but find nothing relevant.

With these settings on a Windows XP virtual machine, both directory .lnk and file .lnk have a bare arrow icon. Is this inconsistency intended?
https://s9.postimg.org/mare6ulr3/image.png

I'm glad you also want the arrow icon back. Maybe by a configurable option? For years this humble arrow means "almost always safe to move around or delete" to me, but now I have to think twice.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50861
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

This is because you disabled EXE/LNK icons, so you get generic icons for EXE and LNK files. This is by design has has been like this forever.
Author of Total Commander
https://www.ghisler.com
User avatar
yyang
Member
Member
Posts: 162
Joined: 2007-03-27, 11:41 UTC
Location: China

Post by *yyang »

ghisler(Author) wrote:This is because you disabled EXE/LNK icons, so you get generic icons for EXE and LNK files. This is by design has has been like this forever.
Thanks for your reply, Ghisler. But before TC9, the icon for .lnk files were the bare arrow (with "Show icons" set to "All associated"). Please see petermad's screenshot here:
http://madsenworld.dk/tcmd/linkarrows8.png

The "slow" hint for "All associated + EXE/LNK" had long convinced me to use the second option (plus not showing overlay icons). That's why this seems a breaking change in TC9.
#147523
User avatar
petermad
Power Member
Power Member
Posts: 16115
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

This is by design has has been like this forever.
No, earlier TC versions (before TC9) used the arrow icon (icon 0012 = no. 13) for .lnk files in that case, but now TC uses icon 0004 or 0014 (no. 5 or no. 15) for .lnk files - it is that change yyang is complaining about.
License #524 (1994)
Danish Total Commander Translator
TC 11.55rc4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1393a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
yyang
Member
Member
Posts: 162
Joined: 2007-03-27, 11:41 UTC
Location: China

Post by *yyang »

petermad wrote:
This is by design has has been like this forever.
No, earlier TC versions (before TC9) used the arrow icon (icon 0012 = no. 13) for .lnk files in that case, but now TC uses icon 0004 or 0014 (no. 5 or no. 15) for .lnk files - it is that change yyang is complaining about.
Exactly! Thanks for putting it in a succinct manner. The arrow looks so intuitive for .lnk files, and I really wish it back.
#147523
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50861
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Ah, I see what you mean - TC9 was showing normal file icons with link overlay now, but only with overlays enabled. I have changed it to use the old icons in RC2 when EXE/LNK icons are disabled.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 16115
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Thanks! Confirmed fixed in TC9rc2 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.55rc4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1393a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
yyang
Member
Member
Posts: 162
Joined: 2007-03-27, 11:41 UTC
Location: China

Post by *yyang »

Fix confirmed, too. A lot of thanks!
#147523
Post Reply