This forum uses cookies. Click X button to hide this message. What is stored? / Privacy
Total Commander Forum Index Total Commander
Forum - Public Discussion and Support
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Reaction to cm_RenameOnly wrong when one object selected

 
Post new topic   Reply to topic    Total Commander Forum Index -> TC9.2x bug reports (English) Printable version
View previous topic :: View next topic  
Author Message
Dalai
Power Member
Power Member


Joined: 28 Jan 2005
Posts: 6000
Location: Meiningen (Südthüringen)

PostPosted: Wed May 16, 2018 3:21 pm    Post subject: Reaction to cm_RenameOnly wrong when one object selected Reply with quote

Hi there,

triggered by the topic Rename function doesn't respect the selected file? I think there's another bug in TC.


  1. Create the following wincmd.ini
    Code:
    [Shortcuts]
    F2=cm_RenameSingleFile
    [Configuration]
    FirstTime=0
    FirstTimeIconLib=0
    Start TC with this new wincmd.ini, like this:
    Code:
    totalcmd.exe /i="D:\wincmd.ini"
    (or wherever you created the file).

  2. Mark exactly one file or directory (e.g. via Insert key)
  3. Move the text cursor away from the selected object
  4. Press F2, which will execute cm_RenameSingleFile (remapped by above wincmd.ini). TC in-place renames the object under the cursor. That's good, because it's expected that cm_RenameSingleFile always operates on the object under the cursor like its description suggests.
  5. Abort the rename operation and press Shift+F6. TC also starts the in-place rename on the file under the cursor. This is wrong. A selection is active and the user expects TC to operate on it when cm_RenameOnly is called (mapped to Shift+F6 by default)
  6. Marking/selecting more than one object shows the dialog to Rename/Move X files, which is also good and expected.


This bug is present in TC 8.52a all the way up to and including 9.20 beta3; I didn't test older versions though because I don't think they're relevant.

(Hope there's a good explanation should this behavior be intentional)

Regards
Dalai
_________________
#101164 Personal licence
Athlon X4 880K, 16 GiB RAM, Gigabyte F2A88X-D3HP, Win7 x64

Plugins: Services2, Startups
Back to top
View user's profile Send private message Send e-mail
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 35473
Location: Switzerland

PostPosted: Thu May 17, 2018 4:00 am    Post subject: Reply with quote

I will check it. According to my code, Shift+F6 invokes cm_renmov.
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
petermad
Power Member
Power Member


Joined: 05 Feb 2003
Posts: 7668
Location: Valsted, Denmark

PostPosted: Thu May 17, 2018 8:11 am    Post subject: Reply with quote

Quote:
Shift+F6 invokes cm_renmov

no - cm_renmov is invoked by F6
_________________
#524
Danish Total Commander Translator
TC 9.12 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit. TC 2.91b2 on Android 6.0

Get Extended Total Commander Menus
Back to top
View user's profile Send private message Send e-mail Visit poster's website
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 35473
Location: Switzerland

PostPosted: Wed May 23, 2018 9:33 am    Post subject: Reply with quote

This should be fixed in Total Commander 9.20 beta 4, please check!
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
Dalai
Power Member
Power Member


Joined: 28 Jan 2005
Posts: 6000
Location: Meiningen (Südthüringen)

PostPosted: Wed May 23, 2018 10:22 am    Post subject: Reply with quote

The problem is only partially fixed. The reaction to cm_RenameOnly command is correct now, but this doesn't apply to Shift+F6. Selecting a single file, moving the cursor away from that file and pressing Shift+F6 still activates in-place rename of the file under the cursor.

Remember that F5, F6, F8/Del and Shift+F5 all operate on the selection, not the file under the cursor, so Shift+F6 should do the same IMO. Also note that the command browser claims that cm_RenameOnly is mapped to Shift+F6 which is clearly not the case (you can try that if you remap F6 or any other key to cm_RenameOnly yourself).

Regards
Dalai
_________________
#101164 Personal licence
Athlon X4 880K, 16 GiB RAM, Gigabyte F2A88X-D3HP, Win7 x64

Plugins: Services2, Startups
Back to top
View user's profile Send private message Send e-mail
petermad
Power Member
Power Member


Joined: 05 Feb 2003
Posts: 7668
Location: Valsted, Denmark

PostPosted: Wed May 23, 2018 7:41 pm    Post subject: Reply with quote

I agree with Dalai - cm_RenameOnly by itself works as expected, but it does not do the same as Shift+F6 when one file is selected and the cursor is on another file
_________________
#524
Danish Total Commander Translator
TC 9.12 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit. TC 2.91b2 on Android 6.0

Get Extended Total Commander Menus
Back to top
View user's profile Send private message Send e-mail Visit poster's website
Display posts from previous:   
Post new topic   Reply to topic    Total Commander Forum Index -> TC9.2x bug reports (English) All times are GMT - 6 Hours
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Imprint/Impressum: This site is maintained by Ghisler Software GmbH
Privacy Policy | Datenschutzerklärung | Politique de Confidentialité

Using phpBB © phpBB Group