This forum uses cookies. Click X button to hide this message. What is stored? / Privacy
Total Commander Forum Index Total Commander
Forum - Public Discussion and Support
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

No crc checksum for .sfv if Rename used

 
Post new topic   Reply to topic    Total Commander Forum Index -> TC Fixed bugs Printable version
View previous topic :: View next topic  
Author Message
DrShark
Power Member
Power Member


Joined: 03 Nov 2006
Posts: 1092
Location: Kyiv, 68/262

PostPosted: Thu May 17, 2018 1:06 am    Post subject: No crc checksum for .sfv if Rename used Reply with quote

This issue also has been reported by email on May 4, 2018 (the one with attached micro TC install to reproduce the issue with unwanted menu self-click).

But currently I didn't get an info whether it was confirmed, and currently in beta 3 it still isn't fixed.

To reproduce:
1. Select sfv file.
2. Choose Create Checksums->CRC32, press Enter.
Overwrite dialog will appear.
3. Choose Rename in Overwrite dialog, set different name for sfv.
Result: TC will create sfv with header, but without crc32 of selected .sfv file.
Expected: TC should create the crc32 for selected sfv file in the sfv which will have new name.

We can see expected behavior if different name is set in path field in step 2 - TC then creates the sfv file with a checksum for selected sfv file.
_________________
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
Back to top
View user's profile Send private message
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 35473
Location: Switzerland

PostPosted: Thu May 17, 2018 3:55 am    Post subject: Reply with quote

It does work with option "Create separate checksum files for each directory". It does not work when no option is checked, because then the list of files is created before renaming, and the same name sfv file is skipped.
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
DrShark
Power Member
Power Member


Joined: 03 Nov 2006
Posts: 1092
Location: Kyiv, 68/262

PostPosted: Thu May 17, 2018 4:32 am    Post subject: Reply with quote

ghisler(Author) wrote:
It does not work when no option is checked, because then the list of files is created before renaming, and the same name sfv file is skipped.
It's easy to forget to check "Create separate checksum files for each directory" in this special case. Maybe you can change the action of Rename button, so after pressing it and if different name is set in reame dialog by user, TC will re-create list of files including selected sfv (in our case its name will be the only name in the list)?
_________________
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
Back to top
View user's profile Send private message
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 35473
Location: Switzerland

PostPosted: Wed May 23, 2018 9:33 am    Post subject: Reply with quote

This should be fixed in Total Commander 9.20 beta 4, please check!
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
DrShark
Power Member
Power Member


Joined: 03 Nov 2006
Posts: 1092
Location: Kyiv, 68/262

PostPosted: Wed May 23, 2018 10:33 am    Post subject: Reply with quote

history920.txt wrote:
18.05.18 Fixed: Create CRC checksums, no options checked: CRC for existing checksum file wasn't created when the user changed the name in the overwrite confirmation dialog (32/64)
Confirm fixed, tested on TC 9.20 beta 4 on Vista 32-bit.
_________________
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    Total Commander Forum Index -> TC Fixed bugs All times are GMT - 6 Hours
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Imprint/Impressum: This site is maintained by Ghisler Software GmbH
Privacy Policy | Datenschutzerklärung | Politique de Confidentialité

Using phpBB © phpBB Group