No crc checksum for .sfv if Rename used

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

No crc checksum for .sfv if Rename used

Post by *DrShark »

This issue also has been reported by email on May 4, 2018 (the one with attached micro TC install to reproduce the issue with unwanted menu self-click).

But currently I didn't get an info whether it was confirmed, and currently in beta 3 it still isn't fixed.

To reproduce:
1. Select sfv file.
2. Choose Create Checksums->CRC32, press Enter.
Overwrite dialog will appear.
3. Choose Rename in Overwrite dialog, set different name for sfv.
Result: TC will create sfv with header, but without crc32 of selected .sfv file.
Expected: TC should create the crc32 for selected sfv file in the sfv which will have new name.

We can see expected behavior if different name is set in path field in step 2 - TC then creates the sfv file with a checksum for selected sfv file.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

It does work with option "Create separate checksum files for each directory". It does not work when no option is checked, because then the list of files is created before renaming, and the same name sfv file is skipped.
Author of Total Commander
https://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Post by *DrShark »

ghisler(Author) wrote:It does not work when no option is checked, because then the list of files is created before renaming, and the same name sfv file is skipped.
It's easy to forget to check "Create separate checksum files for each directory" in this special case. Maybe you can change the action of Rename button, so after pressing it and if different name is set in reame dialog by user, TC will re-create list of files including selected sfv (in our case its name will be the only name in the list)?
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

This should be fixed in Total Commander 9.20 beta 4, please check!
Author of Total Commander
https://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Post by *DrShark »

history920.txt wrote:18.05.18 Fixed: Create CRC checksums, no options checked: CRC for existing checksum file wasn't created when the user changed the name in the overwrite confirmation dialog (32/64)
Confirm fixed, tested on TC 9.20 beta 4 on Vista 32-bit.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
Post Reply