Inconsistent archive handling

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: Hacker, Stefan2, white, sheep

Post Reply
User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Inconsistent archive handling

Post by *MarcinW » 2018-05-17, 19:33 UTC

Initial step: create c:\test\test.zip - it should contain file1.txt and file2.txt (with any contents).

Test 1:
1) go to c:\test
2) press Alt+F7 and search for *.txt files, with "Search archives" option enabled
3) start search - you will see file1.txt and file2.txt in the search results
4) select file1.txt, press F4, edit it and save changes
5) TC asks if repack changed file - choose Yes - file is repacked
6) select file2.txt, press F4, edit it and save changes
7) TC asks if repack changed file - choose Yes - file is repacked

Test 2:
1) as above
2) as above
3) as above
4) press "Feed to listbox" button
5) select file1.txt, press F4 - TC asks if you want to unpack file to temp directory - please note that there was no such question in same situation in Test 1
6) choose Yes, edit the file and save changes
7) TC asks if repack changed file - choose Yes - file is repacked
8) select file2.txt, press F4 - TC says that the operation cannot be performed, because the archive has been modified

I don't know which behavior is right, but there should be no differences between Test 1 and Test 2, since these are identical cases (in sense of archive processing).

Regards

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36418
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-05-18, 10:27 UTC

Sorry, cannot be changed.
This happens because TC cannot reload the zip contents in Test 2 after feed to listbox - it would have to repeat the search for that.
Author of Total Commander
http://www.ghisler.com

User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW » 2018-05-18, 10:31 UTC

Ok, sounds reasonable. But why don't you need to repeat search in Test 1?

User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW » 2018-05-22, 10:14 UTC

Om more note: when TC asks if you want to unpack file to temp directory - is this question in practice helpful?

If yes, it should appear also in Test 1.

If not, maybe it could be just removed?

Regards

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36418
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-05-22, 14:35 UTC

I prefer to keep it as it is now, sorry.
Author of Total Commander
http://www.ghisler.com

User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW » 2018-05-22, 23:15 UTC

:(

Post Reply