Icons for special folder replaced after Ctrl+R

Bug reports will be moved here when the described bug has been fixed

Moderators: Stefan2, white, sheep, Hacker

Post Reply
WetMouse
Junior Member
Junior Member
Posts: 5
Joined: 2018-07-10, 14:42 UTC

Icons for special folder replaced after Ctrl+R

Post by *WetMouse » 2018-07-10, 14:51 UTC

Windows 7, TC 32bit.
When the "show special folder icons" option is turned on, the system icon (for example, for the folder "C:\Documents and Settings") is drawn, but after the update (Ctrl+R) the icon is replaced with the icon from Total Commander.

User avatar
petermad
Power Member
Power Member
Posts: 8073
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad » 2018-07-11, 00:51 UTC

Not confirmed. TC 9.20 32bit and 64bit, Windows 7 Pro
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.92b1 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36557
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-07-11, 06:51 UTC

Not confirmed either. It's possible that the icon loading thread is busy with other things, so it can take a moment to reload such icons. In a worst case, it can take several minutes, e.g. when it tries to load an icon from a network share which is no longer accessible.
Author of Total Commander
http://www.ghisler.com

WetMouse
Junior Member
Junior Member
Posts: 5
Joined: 2018-07-10, 14:42 UTC

Post by *WetMouse » 2018-07-11, 08:55 UTC

I repeated this problem with a clean install on Win Server 2012 R2.
Icon changed only after Ctrl+R.
See imgur_com_gallery_ptDGkZM

Sorry, can't post u_r_l_s.

User avatar
Dalai
Power Member
Power Member
Posts: 6319
Joined: 2005-01-28, 22:17 UTC
Location: Meiningen (Südthüringen)

Post by *Dalai » 2018-07-11, 11:24 UTC

Clickable link: https://imgur.com/gallery/ptDGkZM

2WetMouse
Where exactly do you see a problem? The icons are not replaced by the TC icon, TC just redraws the exclamation mark icon that marks hidden objects. Note that the exclamation mark icon is there already, it just gets redrawn.

[EDIT]
I meant exclamation mark, not question mark.
[/EDIT]


Regards
Dalai
Last edited by Dalai on 2018-07-11, 12:38 UTC, edited 1 time in total.
#101164 Personal licence
Athlon X4 880K, 16 GiB RAM, Gigabyte F2A88X-D3HP, Win7 x64

Plugins: Services2, Startups

WetMouse
Junior Member
Junior Member
Posts: 5
Joined: 2018-07-10, 14:42 UTC

Post by *WetMouse » 2018-07-11, 11:54 UTC

2 Dalai
Thanks for link.
The problem is visible on folders with junction/symlink (All Users, Documents and Settings). On the folders an overlay with an arrow is displayed. First you see a system overlay, but after Ctrl+R it is replaced with an overlay from TC that looks different.

A large blue arrow above the exclamation changes to a small black arrow under an exclamation.

User avatar
Dalai
Power Member
Power Member
Posts: 6319
Joined: 2005-01-28, 22:17 UTC
Location: Meiningen (Südthüringen)

Post by *Dalai » 2018-07-11, 12:37 UTC

WetMouse wrote:On the folders an overlay with an arrow is displayed. First you see a system overlay, but after Ctrl+R it is replaced with an overlay from TC that looks different.
Neither the exclamation mark nor the link arrow are system overlays. Both of them are TC icons/overlays. Both icons (exclamation mark and link arrow) are there, before and after you press Ctrl+R. The only difference is that the exclamation mark is drawn under the link arrow before you refresh the panel and over the link arrow after doing so.

To summarize:
  • Before refresh: Link arrow drawn over exclamation mark
  • After refresh: exclamation mark drawn over link arrow
There is no replacement of icons taking place, it's just the order in which the icons are drawn.

Regards
Dalai
#101164 Personal licence
Athlon X4 880K, 16 GiB RAM, Gigabyte F2A88X-D3HP, Win7 x64

Plugins: Services2, Startups

WetMouse
Junior Member
Junior Member
Posts: 5
Joined: 2018-07-10, 14:42 UTC

Post by *WetMouse » 2018-07-11, 12:59 UTC

2Dalai
This is not entirely true. For symbolic links - before refresh a system arrow is drawn.
I made a more illustrative example - I disabled the exclamation mark and used a custom icon library.

Image: http://i.imgur.com/fcwamd5.gif
Last edited by WetMouse on 2018-07-11, 17:45 UTC, edited 1 time in total.

User avatar
petermad
Power Member
Power Member
Posts: 8073
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad » 2018-07-11, 13:03 UTC

I can confirm this:
Before Ctrl+R: http://madsenworld.dk/tcmd/overlaylnk1.png
After Ctrl+R: http://madsenworld.dk/tcmd/overlaylnk2.png

Setting: http://madsenworld.dk/tcmd/overlaylnk2.png

Actually, I don't need to press Ctrl+R, just take focus away form TC and back on (WatchDirs=55) does it.

In TC 9.10 the overlay arrows for LNK's are shown permanently.
As from TC 9.12rc2 the overlay arrows are not shown. When I press Ctrl+R they are shown for a split second and then dissapears.
TC 9.20b1 behaves the same way as TC 9.20 final.

I don't use any custom icon library.
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.92b1 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36557
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-07-12, 10:06 UTC

Not confirmed so far. Do you get this with a fresh ini? If no, which options do you need to set?

There is one thing I noticed, though, e.g. for folder "Programme" pointing to "Program Files": When overlay icons are enabled, and using the internal folder icons (not from Explorer), the icon may sometimes show the Windows overlay arrow, and sometimes the internal overlay arrow.
Author of Total Commander
http://www.ghisler.com

WetMouse
Junior Member
Junior Member
Posts: 5
Joined: 2018-07-10, 14:42 UTC

Post by *WetMouse » 2018-07-12, 12:56 UTC

I used these settings: Image: https://i.imgur.com/9te6Mt6.png
ghisler(Author) wrote:the icon may sometimes show the Windows overlay arrow, and sometimes the internal overlay arrow.
Yes, this is the crux of the problem.

User avatar
petermad
Power Member
Power Member
Posts: 8073
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad » 2018-07-12, 16:05 UTC

2ghisler(Author)

Use this wincmd.ini:

Code: Select all

[Configuration]
ShowHiddenSystem=1
UseLongNames=1
Small83Names=0
IconOverlays=1
IconsSpecialFolders=3
Showicons=2
ShowEXEandLNKicons=2
IconsInMenus=17
IconsOnNet=1
OldListIcons=1
FirstTimeIconLib=0
[left]
path=c:\Users\Default\
There will be no overlay arrows on the <LNK> entries - now press Ctrl+R and there will be.

It seems to be the IconOverlays=1 that is the culprit - If I set IconOverlays=0, then the overlay arrows are shown all the time, even though they should not be shown at all.
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.92b1 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36557
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Icons for special folder replaced after Ctrl+R

Post by *ghisler(Author) » 2018-07-25, 13:38 UTC

This should be fixed in TC 9.21 rc1, please test it! TC now uses its own link overlay icon for these file system links.
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 8073
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: Icons for special folder replaced after Ctrl+R

Post by *petermad » 2018-07-25, 16:03 UTC

Confirmed fixed in TC 9.21rc1 :-)

I would still expect no link overlays for folders to be shown if IconOverlays=0 though...?
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.92b1 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36557
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Icons for special folder replaced after Ctrl+R

Post by *ghisler(Author) » 2018-07-26, 07:52 UTC

IconOverlays=0 is meant to turn off the (sometimes slow, sometimes faulty) loading of overlays via OLE2. The link icons for these file system links are internal icons and don't need complex loading. File system links are also very dangerous, depending on the operation performed, so I prefer to always warn the user about them.
Author of Total Commander
http://www.ghisler.com

Post Reply