Dark Mode: Sync Dirs Compare button different state color after mouse and keyboard press

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: sheep, Hacker, Stefan2, white

Post Reply
User avatar
DrShark
Power Member
Power Member
Posts: 1548
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Dark Mode: Sync Dirs Compare button different state color after mouse and keyboard press

Post by *DrShark »

To reproduce:
1. In TC with dark mode active, while being in some dir with deep tree, open Synchronize Directories dialog.
2. Check Subdirs checkbox in Synchronize Directories dialog.
3. Click on Compare button with mouse, don't move mouse pointer away from button until its state will change to "disabled".
When comparison of files and directories is started and button has "disabled" state, its background color is still gray.

If to start comparison after opening Sync Dirs by pressing Alt+C (on English TC UI), Enter, or Space, or with left mouse button but with moving the pointer immediately after click away from Compare button until its state is changed, then when state will change to "disabled", button background will be black.

Reproduced on TC 9.50 beta 11 using Vista 32-bit with classic theme.
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39117
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Dark Mode: Sync Dirs Compare button different state color after mouse and keyboard press

Post by *ghisler(Author) »

The only difference I can see is that the button has a larger border, but that's because it's the default button. On the second compare, the "Synchronize..." button is the default, so the compare button as a smaller border.
Author of Total Commander
http://www.ghisler.com

User avatar
DrShark
Power Member
Power Member
Posts: 1548
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: Dark Mode: Sync Dirs Compare button different state color after mouse and keyboard press

Post by *DrShark »

ghisler(Author) wrote:
2020-01-08, 11:24 UTC
The only difference I can see is that the button has a larger border, but that's because it's the default button. On the second compare, the "Synchronize..." button is the default, so the compare button as a smaller border.
Today I sent a video of issue to support email.
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
DrShark
Power Member
Power Member
Posts: 1548
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: Dark Mode: Sync Dirs Compare button different state color after mouse and keyboard press

Post by *DrShark »

In email Christian Ghisler explained that colors of Compare button pressed in dark mode with mouse and keyboard are different because after mouse click it gets focused/default+disabled state, and after pressing with keyboard it gets unfocused+disabled state.

He didn't write, however, whether it is a bug or intentional behavior.

BTW, other buttons in dark mode, like Apply button in Total Commander Configuration dialog, behave the same way.
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
DrShark
Power Member
Power Member
Posts: 1548
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: Dark Mode: Sync Dirs Compare button different state color after mouse and keyboard press

Post by *DrShark »

Since this moved to behaviour will not be changed, it's intentional, but questions remain:
1. Why after pressing the button with mouse it gets focused/default+disabled state, but after pressing with keyboard - unfocused+disabled state state?
2. Why if to move mouse pointer away from button immediately after clicking it, the button doesn't get focused/default+disabled state but uses unfocused+disabled state instead?
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39117
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Dark Mode: Sync Dirs Compare button different state color after mouse and keyboard press

Post by *ghisler(Author) »

It seems to be a timing problem it gets unfocused first and then disabled when using the keyboard
Author of Total Commander
http://www.ghisler.com

User avatar
DrShark
Power Member
Power Member
Posts: 1548
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: Dark Mode: Sync Dirs Compare button different state color after mouse and keyboard press

Post by *DrShark »

ghisler(Author) wrote:
2020-01-17, 16:00 UTC
It seems to be a timing problem it gets unfocused first and then disabled when using the keyboard
Is it possible to solve this by adding timers for problem buttons, like you have done for listbox scrollbars already?
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

Post Reply