TC9.50b12a, Dark Mode: tree nodes issues

Bug reports will be moved here when the described bug has been fixed

Moderators: sheep, Hacker, Stefan2, white

User avatar
DrShark
Power Member
Power Member
Posts: 1622
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

TC9.50b12a, Dark Mode: tree nodes issues

Post by *DrShark »

Following issues found with this change:
HISTORY.TXT wrote:10.01.20 Fixed: Dark mode, tree view: Show [+] icons to expand tree nodes instead of triangles ">", also after switching from normal to dark mode (32/64)
1. When dark TC is launched with default settings:

Code: Select all

[ColorsDark]
TreeTriangles=-1
64-bit TC is started with triangle tree icons, although it starts using plus ([+]) after executing cm_switchdatkmode twice.
2. If to force triangle ([>]) nodes for dark mode:

Code: Select all

[ColorsDark]
TreeTriangles=1
32-bit TC ignores it and uses [+] anyway;
64-bit TC uses triangles at start but switches to [+] after executing cm_switchdatkmode twice.
3. If to force [+] nodes for dark mode:

Code: Select all

[ColorsDark]
TreeTriangles=0
both 32-bit and 64-bit TC use [+] nodes both at start and after executing cm_switchdatkmode twice, so it works as expected.
In this case [+] node icons are smaller then in case 1 and case 2.

In all above cases TreeTriangles parameter wasn't defined in [Colors] section of wincmd.ini, which means TreeTriangles=-1 used for normal mode.

Tested on Windows 10 1903 64-bit in Total Commander 9.50 beta 12a.
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
petermad
Power Member
Power Member
Posts: 9810
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *petermad »

10.01.20 Fixed: Dark mode, tree view: Show [+] icons to expand tree nodes instead of triangles ">", also after switching from normal to dark mode (32/64)
It seems thaty this fix doersn work quite as expected

Under Windows 7 I can NEVER get triangles in Dark mode no matter what setting I use for TreeTriangles in either the [Colors] and/or [ColorsDark] section.

But if I switch from Dark to Normal mode the +'s that should be shown - is not there - in stead I see some diminutive triangles - see: https://madsenworld.dk/tcmd/triangles.png


Under Windows 10 1909 with 64bit TC and no TreeTriangles setting in [Colors] I get this when starting in Dark mode:
With [ColorsDark] TreeTriangles=-1 I see triangles.
With [ColorsDark] TreeTriangles=0 I see +'s.
With [ColorsDark] TreeTriangles=1 I see triangles.

if I switch from Dark to Normal mode the +'s that should be shown is not there - in stead I see the diminutive triangles, and if [ColorsDark] TreeTriangles=0 I also see dimunitive triangles when if I switch back to Dark mode again - see: https://madsenworld.dk/tcmd/triangles2.png


Under Windows 10 1909 with 32bit TC and no TreeTriangles setting in [Colors] I get this when starting in Dark mode:
With [ColorsDark] TreeTriangles=-1 I see triangles.
With [ColorsDark] TreeTriangles=0 I see diminutive triangles - see: https://madsenworld.dk/tcmd/triangles3.png
With [ColorsDark] TreeTriangles=1 I see triangles.

So it is not possible to see +'s in Dark mode in 32bit TC!

if I switch from Dark to Normal mode the +'s that should be shown is not there - in stead I see the diminutive triangles.


If I set [Colors] TreeTriangles=1 I will always get triangles in Normal mode also if I switch back and forth between Dark and Normal mode - in both 32bit and 64bit TC

If I set [Colors] TreeTriangles=0 I will always get diminutive triangles (in stead of the expected +'s) in Normal mode when I switch back and forth between Dark and Normal mode - in both 32bit and 64bit TC

Notice, I have TreeLineColor=0 in my [Colors] section.
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.988 (x64)
TC 3.10b8 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39929
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *ghisler(Author) »

Sorry, TreeTriangles was indeed ignored. I will fix it.
Author of Total Commander
http://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1622
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *DrShark »

history950.txt wrote:12.01.20 Fixed: Option TreeTriangles in section [Colors] was ignored after recent fix (Show [+] icons to expand tree nodes). Note: TreeTriangles in [ColorsDark] is only used in Windows 10 1809 and newer (32/64)
First, the question: why TreeTriangles support in [ColorsDark] is implemented only for W10 1809+ while triangles are used since Win7?

Now about tested bugfix:
0. All tests done on W10 1903 with light theme that has problems with dark TC, solved also in beta 13 currently only for 32-bit TC, which means currently in this environment ForceDarkModeOptions behave differently in 32-and 64-bit TC.

1. All tests done without TreeTriangles in section [Colors], which means TreeTriangles=-1 because my focus was TreeTriangles behavior in dark mode.
With this setting here on W10 in normal (light) mode TC uses arrows [>] as node icons in all cases as expected.

2. With TreeTriangles set as -1 or 0 in [ColorsDark] section, TC used large [+] icons, while with TreeTriangles=1 in [ColorsDark] it used small [+] icons.

3. Details on cases where usage of [+] or [>] in dark mode is unexpected:

if [ColorsDark], TreeTriangles set as -1 (let TC decide the icon) and
* with [Configuration], ForceDarkModeOptions=1:
64-bit TC unexpectedly starts in dark mode with [>], and on switch to dark mode from light is also uses [>] instead of [+].

* with [Configuration], ForceDarkModeOptions=2:
64 bit TC unexpectedly uses [>], but on switch to dark mode from light it uses [+] which is expected.

if [ColorsDark], TreeTriangles set as 0 (TC shows [+] icon) and
* with [Configuration], ForceDarkModeOptions=1 or 2, both 32-bit and 64 bit in dark made always use [+], which is expected, so no problems here.

if [ColorsDark], TreeTriangles set as 1 (TC shows [>] icon) and
* with [Configuration], ForceDarkModeOptions=1
32-bit TC unexpectedly starts in dark mode with [+] icon, and on switch to dark mode from light is also unexpectedly uses [+].
* with [Configuration], ForceDarkModeOptions=2
32-bit TC unexpectedly starts in dark mode with [+] icon, and on switch to dark mode from light is also unexpectedly uses [+].
64 bit TC on start in dark mode uses with expected [>], BUT on switch to dark mode from light it unexpectedly uses [+].
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39929
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *ghisler(Author) »

why TreeTriangles support in [ColorsDark] is implemented only for W10 1809+ while triangles are used since Win7?
Because older Windows versions don't have a dark theme for tree triangles, so I would be using the triangles from light mode - they are barely visible in dark mode.
Author of Total Commander
http://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1622
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *DrShark »

ghisler(Author) wrote:
2020-01-16, 11:39 UTC
why TreeTriangles support in [ColorsDark] is implemented only for W10 1809+ while triangles are used since Win7?
Because older Windows versions don't have a dark theme for tree triangles, so I would be using the triangles from light mode - they are barely visible in dark mode.
What do you mean by "dark theme for tree triangles"? Here on Windows 7 32-bit triangles in dark mode are dark, and on Windows 10 64-bit they're also dark (or rather black, and larger than on Windows 7).
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
petermad
Power Member
Power Member
Posts: 9810
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *petermad »

But if I switch from Dark to Normal mode the +'s that should be shown - is not there - in stead I see some diminutive triangles - see: https://madsenworld.dk/tcmd/triangles.png
Fixed in TC 9.5b13 :-)

if I switch from Dark to Normal mode the +'s that should be shown is not there - in stead I see the diminutive triangles, and if [ColorsDark] TreeTriangles=0 I also see dimunitive triangles when if I switch back to Dark mode again - see: https://madsenworld.dk/tcmd/triangles2.png
Fixed in TC 9.5b13 :-)

Under Windows 10 1909 with 32bit TC and no TreeTriangles setting in [Colors] I get this when starting in Dark mode:
With [ColorsDark] TreeTriangles=0 I see diminutive triangles - see: https://madsenworld.dk/tcmd/triangles3.png
Fixed in TC 9.5b13 :-)

So it is not possible to see +'s in Dark mode in 32bit TC!

if I switch from Dark to Normal mode the +'s that should be shown is not there - in stead I see the diminutive triangles.
Fixed in TC 9.5b13 :-)

If I set [Colors] TreeTriangles=0 I will always get diminutive triangles (in stead of the expected +'s) in Normal mode when I switch back and forth between Dark and Normal mode - in both 32bit and 64bit TC
Fixed in TC 9.5b13 :-)


Why is it that if I set [Colors] TreeTriangles=-1 I get +'s and if I set [ColorsDark] TreeTriangles=-1 I get triangles?
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.988 (x64)
TC 3.10b8 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
petermad
Power Member
Power Member
Posts: 9810
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *petermad »

2. With TreeTriangles set as -1 or 0 in [ColorsDark] section, TC used large [+] icons, while with TreeTriangles=1 in [ColorsDark] it used small [+] icons.
I cannot confirm this in Win 10 1909 with TC 9.5b13.

Concerning the influence of the ForceDarkModeOptions setting:
[Colors] TreeTriangles=-1
[ColorsDark] TreeTriangles=-1
ForceDarkModeOptions=1: TC 64bit and 32bit starts Dark mode with >'s.
ForceDarkModeOptions=2: TC 64bit starts Dark mode with >'s and TC 32bit starts Dark mode with +'s.

Switching from Dark to Normal mode and back to Dark mode:
ForceDarkModeOptions=1: TC 64bit and 32bit shows >'s after the switch.
ForceDarkModeOptions=2: TC 64bit and and 32bit shows +'s after the switch.



[Colors] TreeTriangles=-1
[ColorsDark] TreeTriangles=1
ForceDarkModeOptions=1: TC 64bit and 32bit starts Dark mode with >'s.
ForceDarkModeOptions=2: TC 64bit starts Dark mode with >'s and TC 32bit starts Dark mode with +'s.

Switching from Dark to Normal mode and back to Dark mode:
ForceDarkModeOptions=1: TC 64bit and 32bit shows >'s after the switch.
ForceDarkModeOptions=2: TC 64bit and and 32bit shows +'s after the switch.
Last edited by petermad on 2020-01-17, 04:27 UTC, edited 3 times in total.
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.988 (x64)
TC 3.10b8 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
DrShark
Power Member
Power Member
Posts: 1622
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *DrShark »

petermad wrote:
2020-01-16, 19:19 UTC
2. With TreeTriangles set as -1 or 0 in [ColorsDark] section, TC used large [+] icons, while with TreeTriangles=1 in [ColorsDark] it used small [+] icons.
I cannot confirm this in Win 10 1909.
Some screenshots of dark TC 9.50 beta 13 from W10 1903 w/ light theme:

- plus icons:
* 32-bit TC uses small [+] icons (ForceDarkModeOptions=1 + [ColorsDark] TreeTriangles=0): http://live.staticflickr.com/65535/49395701628_4181e60756_o.png
* 32-bit TC uses large [+] icons (ForceDarkModeOptions=2 + [ColorsDark], TreeTriangles=1): http://live.staticflickr.com/65535/49396385647_6abd7a9707_o.png

- dark arrow icons:
* 64-bit TC (ForceDarkModeOptions=2, [ColorsDark] TreeTriangles=1): http://live.staticflickr.com/65535/49396385607_fc16f625c8_o.png
* 64-bit TC (ForceDarkModeOptions=1 and [ColorsDark], TreeTriangles=1):
http://live.staticflickr.com/65535/49395701583_1973f64e6a_o.png
* 32-bit TC (older beta 12) on 32-bit Windows 7: http://live.staticflickr.com/65535/49395701393_bd3d1b07f2_o.jpg
petermad wrote:
2020-01-16, 19:19 UTC
[Colors] TreeTriangles=-1
[ColorDark] TreeTriangles=-1
...
Switching from Dark to Normal mode and back to Dark mode:
...
ForceDarkModeOptions=2: TC 64bit and and 32bit shows +'s after the switch.
You colored this in red meaning it's not expected, but TreeTriangles=-1 (let TC decide) since beta 12a tells TC to use [+] in dark mode, so when after switching it to dark mode it uses [+] that's exactly what should happen.
petermad wrote:
2019-11-17, 20:01 UTC
By Default TC shows triangles (in newer OS's), but if TreeLineColor=0 (black) and TreeTriangles=-1 TC decides to show [+]'s
In my tests I didn't check TreeLineColor=0 influence on TreeTriangles=-1 in [Colors] or [ColorsDark].
Last edited by DrShark on 2020-01-17, 16:47 UTC, edited 4 times in total.
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
petermad
Power Member
Power Member
Posts: 9810
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *petermad »

In TC 9,5b13 if nothing is set for TreeTriangles and TreeLineColor for both [Colors] and [ColorsDark] TC shows triangles in Both Normal and Dark mode under Windows 10 1909, so we must assume that >'s is the default. Under Windows 7 +'s are used for Dark mode according to Ghisler. I have EDITED my last report to reflect that, so that results in red are unexpected.
32-bit TC uses large [+] icons (ForceDarkModeOptions=2 + [ColorsDark], TreeTriangles=1): http://live.staticflickr.com/65535/49396385647_fb05ce3b2d_w.jpg
I cannot get those BIG +'s - here is how it looks by me: https://madsenworld.dk/tcmd/32bitforcedark2.png

* 64-bit TC (ForceDarkModeOptions=2 and [ColorsDark], TreeTriangles=1): http://live.staticflickr.com/65535/49396385607_1c35c2d4f8_w.jpg
* 32-bit TC (ForceDarkModeOptions=1, [ColorsDark] TreeTriangles=1): http://live.staticflickr.com/65535/49395701583_311956e6e4_w.jpg
* 32-bit TC (older beta 12) on 32-bit Windows 7: http://live.staticflickr.com/65535/49395701393_76e2c13537_w.jpg
Sorry those images are to small to see the nodes reliably on :-(

In my tests I didn't check TreeLineColor=0 influence on TreeTriangles=-1 in [Colors] or [ColorsDark].
With ForceDarkModeOptions=1/2 and TreeTriangles=-1 - TreeLineColor=0 results in +'s - in Dark mode (unexpected), but not in Normal mode.
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.988 (x64)
TC 3.10b8 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
DrShark
Power Member
Power Member
Posts: 1622
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *DrShark »

petermad wrote:
2020-01-17, 03:14 UTC
In TC 9,5b13 if nothing is set for TreeTriangles and TreeLineColor for both [Colors] and [ColorsDark] TC shows triangles in Both Normal and Dark mode under Windows 10 1909, so we must assume that >'s is the default.
I disagree. The point of fix:
10.01.20 Fixed: Dark mode, tree view: Show [+] icons to expand tree nodes instead of triangles ">", also after switching from normal to dark mode (32/64)
is to make [+] by default in dark mode (and when TreeTriangles=-1 or not set TC exactly uses default settings), because dark/black triangles are poorly visible, so hard to click on dark tree background.
petermad wrote:
2020-01-17, 03:14 UTC
DrShark wrote:
2020-01-16, 23:02 UTC
* 64-bit TC (ForceDarkModeOptions=2 and [ColorsDark], TreeTriangles=1): http://live.staticflickr.com/65535/49396385607_1c35c2d4f8_w.jpg
* 32-bit TC (ForceDarkModeOptions=1, [ColorsDark] TreeTriangles=1): http://live.staticflickr.com/65535/49395701583_311956e6e4_w.jpg
* 32-bit TC (older beta 12) on 32-bit Windows 7: http://live.staticflickr.com/65535/49395701393_76e2c13537_w.jpg
Sorry those images are to small to see the nodes reliably on :-(
I edited the post to point links to original size of uploaded pictures (removed _w before .jpg from links).
petermad wrote:
2020-01-17, 03:14 UTC
With ForceDarkModeOptions=1/2 and TreeTriangles=-1 - TreeLineColor=0 results in +'s - in Dark mode (unexpected), but not in Normal mode.
So it's a bug of normal mode then?
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
petermad
Power Member
Power Member
Posts: 9810
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *petermad »

* 64-bit TC (ForceDarkModeOptions=2 and [ColorsDark], TreeTriangles=1): http://live.staticflickr.com/65535/49396385607_1c35c2d4f8.jpg
This is also not how triangles looks in Dark mode for me - here it look like this in TC 9.5b13 under Windows 10 1909:
64-bit TC, ForceDarkModeOptions=2 and [ColorsDark] TreeTriangles=1: https://madsenworld.dk/tcmd/forcedark1triangles1.png
32-bit TC, ForceDarkModeOptions=1 and [ColorsDark] TreeTriangles=1: https://madsenworld.dk/tcmd/forcedark2triangles1.png
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.988 (x64)
TC 3.10b8 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
DrShark
Power Member
Power Member
Posts: 1622
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *DrShark »

I mixed up descriptions of some screenshots (obviously screenshot with light scrollbar is from 64-bit TC, some other descriptions were wrong too) in my above post, so I corrected it now.
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
Usher
Power Member
Power Member
Posts: 884
Joined: 2011-03-11, 10:11 UTC

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *Usher »

DrShark wrote:
2020-01-17, 07:34 UTC
I edited the post to point links to original size of uploaded pictures (removed _w before .jpg from links).
And they are also resized by the server-side, only a little bit larger than _w files. It seems that Flickr wants users to buy premium support so it's better to use other picture hosting.
Regards from Poland
Andrzej P. Wozniak
User avatar
DrShark
Power Member
Power Member
Posts: 1622
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *DrShark »

Usher wrote:
2020-01-17, 15:57 UTC
DrShark wrote:
2020-01-17, 07:34 UTC
I edited the post to point links to original size of uploaded pictures (removed _w before .jpg from links).
And they are also resized by the server-side
Actually original pictures have not only different _o prefix but also very different unique urls. I edited the post again so links now point to original files, but usually I don't post here links to pictures with size larger and quality better than required to see the problem pictured on screenshot.
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
Post Reply