[Tc11] [added,fixed] Ignorelist: Suggestion to the new extended Features

Here you can propose new features, make suggestions etc.

Moderators: white, Hacker, petermad, Stefan2

JOUBE
Power Member
Power Member
Posts: 1507
Joined: 2004-07-08, 08:58 UTC

Re: [Tc11] Ignorelist: Suggestion to the new extended Features

Post by *JOUBE »

ghisler(Author) wrote: 2023-05-10, 14:10 UTC
#Secure FTP:\1 a b {c}\*\01__xx\ folder is ignored. this is not okay. Why?
I cannot reproduce that, the name has to match exactly.
It is simple: There is no file system plugin with the name "#Secure FTP" (the name of the plugin is 'Secure FTP') . So you should not use this rule in the ignorelist. It seems that you only trigger on the ':' and not on the plugin name. But you should check the plugin name also, because the ignorage depends from the plugins. And this can be different from plugin to plugin.

JOUBE

Edit: So you do not have to use this rule in the ignorelist --> So you should not use this rule in the ignore list
Last edited by JOUBE on 2023-05-10, 17:20 UTC, edited 2 times in total.
JOUBE
Power Member
Power Member
Posts: 1507
Joined: 2004-07-08, 08:58 UTC

Re: [Tc11] Ignorelist: Suggestion to the new extended Features

Post by *JOUBE »

ghisler(Author) wrote: 2023-05-10, 14:10 UTC
see my posting directly above yours
I asked because I did not understand what's wrong in the posting above my last. Please reply to my questions 1-3.
1. How does the entry in the ignore list look like which doesn't work?
Answer: Secure FTP:\1 a b {c}\*\01__xx\
(Note: Everything works fine, but only after the first folder change.)

2. What path name is shown above the file list where the ignore list doesn't work?
Answer: \\\Secure FTP\1 a b {c}\home\user\*.*

3. What file name isn't ignored?
Answer: It is a folder: 01__xx/
(folder /home/user/01__xx/ is visible and not ignored until the first folder change)
(Note: Everything works fine, but only after the first folder change.)

The bug: At this first 'landing' (after connect) the "ignorage" does not work. After the first folder change everything is okay.

It's just such an initialization of "ignorage" that's missing after connecting and before reading the file list. That's all.

Connection name '1 a b {c}', Connecting to server: 10.0.0.2:22/home/user

JOUBE
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48231
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [Tc11] Ignorelist: Suggestion to the new extended Features

Post by *ghisler(Author) »

I can reproduce the problem:
1. When 01__xx is located in a subdirectory and I connect directly to that subdirectory by specifying it in the connection settings like this:
10.0.0.2:22/home/user
Then the folder 01__xx is not hidden.
2. It gets hidden when I press Ctrl+R
3. It is also hidden from the start when I change the ignore list entry to:
Secure FTP:\1 a b {c}\*\01__xx
Please note the missing backslash at the end!
Author of Total Commander
https://www.ghisler.com
JOUBE
Power Member
Power Member
Posts: 1507
Joined: 2004-07-08, 08:58 UTC

Re: [Tc11] Ignorelist: Suggestion to the new extended Features

Post by *JOUBE »

ghisler(Author) wrote: 2023-05-11, 08:20 UTC I can reproduce the problem:
1. When 01__xx is located in a subdirectory and I connect directly to that subdirectory by specifying it in the connection settings like this:
10.0.0.2:22/home/user
Then the folder 01__xx is not hidden.
2. It gets hidden when I press Ctrl+R
3. It is also hidden from the start when I change the ignore list entry to:
Secure FTP:\1 a b {c}\*\01__xx
Please note the missing backslash at the end!

@ 2. Ctrl+R is same as folder change: reread the current folder
@ 3. No here no difference (debian(11), fedora38 ) between
Secure FTP:\1 a b {c}\*\01__xx and
Secure FTP:\1 a b {c}\*\01__xx\

Result:
- your workaround (3.) doesn't work for me.
- Please reread (or what ever else) the current folder after connect.
- To remove the \ at the end of the rule in ingnorellist for a folder is inconsistent.

JOUBE

PS.: And what's about the file system plugin name bug in ignorelist?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48231
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [Tc11] Ignorelist: Suggestion to the new extended Features

Post by *ghisler(Author) »

1. I found that the ignore list isn't used when following a link, and connections are presented as links. I will fix it.
2. I could not reproduce the plugin name bug.
Author of Total Commander
https://www.ghisler.com
JOUBE
Power Member
Power Member
Posts: 1507
Joined: 2004-07-08, 08:58 UTC

Re: [Tc11] Ignorelist: Suggestion to the new extended Features

Post by *JOUBE »

ghisler(Author) wrote: 2023-05-12, 10:24 UTC 1. I found that the ignore list isn't used when following a link, and connections are presented as links. I will fix it.
Ah, a more generally issue. Thanks for fixing.
ghisler(Author) wrote: 2023-05-12, 10:24 UTC 2. I could not reproduce the plugin name bug.
I will do some additional tests and report here.

What's about the trailing folder backslash? Is it working now?
JOUBE
Power Member
Power Member
Posts: 1507
Joined: 2004-07-08, 08:58 UTC

Re: [Tc11] Ignorelist: Suggestion to the new extended Features

Post by *JOUBE »

JOUBE wrote: 2023-05-12, 15:26 UTC
ghisler(Author) wrote: 2023-05-12, 10:24 UTC 2. I could not reproduce the plugin name bug.
I will do some additional tests and report here.
The test:
This line enables ignorage within SFTP plugin:
Secure FTP:\1 a b {c}\*\01__xx

But this line enables ignorage within SFTP plugin also (!):
XXXXXXXXX:\1 a b {c}\*\01__xx

Second line is not okay. This is a bug. *) And not a feature or by design...

JOUBE

*) How to distinguish plugins with this bug? How to comment out lines? Apparently it only triggers on ':' or '\*\' and not - as it should be on the beginning of the line and the plugin name.

PS.: What's about the trailing folder backslash? Will it work? It should...
JOUBE
Power Member
Power Member
Posts: 1507
Joined: 2004-07-08, 08:58 UTC

Re: [Tc11] Ignorelist: Suggestion to the new extended Features

Post by *JOUBE »

Code: Select all

17.05.23 Release Total Commander 11.00 beta 3
....
15.05.23 Fixed: Ignore list with plugins: The plugin name wasn't checked when using wildcards, e.g. Secure FTP:\connection\*\name (32/64)
...
12.05.23 Fixed: File system plugins: The initial directory directly after connecting to a server (e.g. in SFTP) didn't use the ignore list (32/64)
@ghisler(author)

Thank you Sir. Nearly *) everything works perfect.

Even der trailing backslash at folders is working.

Now it's possible to handle ignore list like it should for file system plugins.

The handling is now restored as with conf files in linux distributions: it is possible to comment lines out (with # or what ever), as it was previously possible now also for file system plugins. To handle different plugins is now possible...

A very useful new feature of Tc11.

JOUBE

*) The only remaining problem are trailing spaces. But this is a general problem of the ignore list. Nice to have, but not so important. I can deal with.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48231
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [Tc11] Ignorelist: Suggestion to the new extended Features

Post by *ghisler(Author) »

Actually there is a way to create files with spaces at the end, and the ignore list will allow you to hide them. Therefore I cannot simply remove spaces at the end of ignore list entries.
Author of Total Commander
https://www.ghisler.com
JOUBE
Power Member
Power Member
Posts: 1507
Joined: 2004-07-08, 08:58 UTC

Re: [Tc11] Ignorelist: Suggestion to the new extended Features

Post by *JOUBE »

ghisler(Author) wrote: 2023-05-18, 07:02 UTC Actually there is a way to create files with spaces at the end, and the ignore list will allow you to hide them. Therefore I cannot simply remove spaces at the end of ignore list entries.
Ok.

I mark this thread as [added, fixed].

Joube
Post Reply