When holding Shift, the tab doesn't get focus after recovery

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
Fla$her
Power Member
Power Member
Posts: 3015
Joined: 2020-01-18, 04:03 UTC

When holding Shift, the tab doesn't get focus after recovery

Post by *Fla$her »

✅ cm_SrcTabsList > Recently closed tabs: Shift + item click/enter = focus switch
❌ cm_DirTabsShowMenu > Recently closed tabs > Shift + item click/enter = focus doesn't switch

Detected when trying to bind em_ (TCFS2) to Shift + T.
Overquoting is evil! 👎
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50824
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: When holding Shift, the tab doesn't get focus after recovery

Post by *ghisler(Author) »

There is no point pressing Shift, both will automatically re-open the recently closed tab directory as a tab, not in the current tab.
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 3015
Joined: 2020-01-18, 04:03 UTC

Re: When holding Shift, the tab doesn't get focus after recovery

Post by *Fla$her »

ghisler(Author) wrote: 2024-03-04, 11:32 UTC There is no point pressing Shift
I kind of made it clear that Shift is a hotkey modifier that navigates to this menu item. >>>
Detected when trying to bind em_ (TCFS2) to Shift + T.

ghisler(Author) wrote: 2024-03-04, 11:32 UTC both will automatically re-open the recently closed tab directory as a tab, not in the current tab.
The reopening was not discussed. It's only about changing focus. See the topic title.
Overquoting is evil! 👎
sa16
Senior Member
Senior Member
Posts: 344
Joined: 2021-09-10, 07:15 UTC

Re: When holding Shift, the tab doesn't get focus after recovery

Post by *sa16 »

When holding Shift, the tab doesn't get focus after recovery
This is correct, just like here:
CTRL+T Open new folder tab and activate it
CTRL+SHIFT+T Open new folder tab, but do not activate it
Fla$her
Power Member
Power Member
Posts: 3015
Joined: 2020-01-18, 04:03 UTC

Re: When holding Shift, the tab doesn't get focus after recovery

Post by *Fla$her »

This is correct, just like here:
Apparently this has an effect, but this is incorrect, because selecting a menu item and a hotkey are two different things.
Also see the first case, which is not affected in any way.
Overquoting is evil! 👎
sa16
Senior Member
Senior Member
Posts: 344
Joined: 2021-09-10, 07:15 UTC

Re: When holding Shift, the tab doesn't get focus after recovery

Post by *sa16 »

History.txt wrote:16.10.19 Release Total Commander 9.50 beta 1
22.07.19 Added: Right click on directory tab -> "Recently closed tabs": Hold down Shift to open restored tab in background (do not activate it) (32/64)
Fla$her
Power Member
Power Member
Posts: 3015
Joined: 2020-01-18, 04:03 UTC

Re: When holding Shift, the tab doesn't get focus after recovery

Post by *Fla$her »

Yeah, that's bad. It turns out that none of the modifiers can work properly with such a command...
Overquoting is evil! 👎
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50824
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: When holding Shift, the tab doesn't get focus after recovery

Post by *ghisler(Author) »

This should be fixed in Total Commander 11.50 beta 1, please check it!
25.03.24 Added: cm_SrcTabsList: Shift+Enter on recently closed tab now restores the tab, but doesn't focus it (32/64)
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 3015
Joined: 2020-01-18, 04:03 UTC

Re: When holding Shift, the tab doesn't get focus after recovery

Post by *Fla$her »

2ghisler(Author)
This contradicts what was written. It should have been done so that after cm_DirTabsShowMenu, focus would set on the restored tab, and not remove after cm_SrcTabsList. As a result, it only got worse.
Overquoting is evil! 👎
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50824
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: When holding Shift, the tab doesn't get focus after recovery

Post by *ghisler(Author) »

No, it's consistent now.

Moderator message from: ghisler(Author) » 2024-10-15, 10:06 UTC

Moved to will not be changed
Author of Total Commander
https://www.ghisler.com
Post Reply