[TC 11.50b1] Black background flash in search window

[vladkosi]

This bug has returned - viewtopic.php?t=79351

Tested on Windows 10 64-bit. The flash is most visible (100 ms) when searching in a directory with many files.

https://i.imgur.com/INagIs2.png

TC 11.03 - https://imgur.com/RS7Uobo
TC 11.50 b1 - https://imgur.com/okDp69C

[AntonyD]

Confirmed! and it's VEEERY easy visible on a slow comp!

[ghisler(Author)]

Back then I fixed the flickering by calling application.ProcessMessages; in the resize function.
Unfortunately this had a bad side effect: When typing search characters before the dialog opened would sometimes select them by mistake.
Here is the relevant thread:
viewtopic.php?t=81817

And here is the documented fix:

25.03.24 Fixed: Alt+F7 search: Typing search characters before the dialog opened would sometimes select them by mistake (64)

I tried calling PeekMessage in a loop, removing just WM_PAINT messages and handling them with DispatchMessage, but the flickering didn't disappear. Maybe I need to handle some other messages?

[vladkosi]

Maybe WM_ERASEBKGND?

[ghisler(Author)]

I will try it.

[ghisler(Author)]

It doesn't seem to help much, but I will keep it in beta 2 for test purposes.

[AntonyD]

What is surprising is that after I returned to using the stable release 11.03
I began to notice that it had exactly the same problems! They were just very rare
or were barely noticed. But now the eyes are suddenly “accustomed to catching” this kind of thing.
And now I see it.

[ghisler(Author)]

That's because 11.03 also draws over that black background, just earlier than 11.50.

[vladkosi]

It seems to be fixed in beta 2 - https://imgur.com/kwNoV2S

I've never noticed it in 11.03.

[ghisler(Author)]

I'm now handling WM_PAINT, WM_ERASEBKGND and the Lazarus-specific LM_PAINT messages immediately, which seems to help a bit.

[white]

I'm now handling WM_PAINT, WM_ERASEBKGND and the Lazarus-specific LM_PAINT messages immediately, which seems to help a bit.

Helps a lot. Tested OK using TC 11.50b2 64-bit.

[AntonyD]

Yep, helps a lot indeed. But I have a strong feelings that now for 1 - 1.5 sec. this dialog appears slower than before...

[ghisler(Author)]

Moderator message from: ghisler(Author) » 2024-10-17, 08:01 UTC

Moved to fixed bugs