[TC 11.50b2] No confirmation before deleting file when using drag&drop

[white]

• Execute cm_Confirmation and disable confirmation for "Drag&Drop (copying file with mouse)"

There is a confirmation dialog when moving files to recycle bin:

1. Right-click the F8 Delete button and select Properties
2. Make sure deleted files are moved to recycle bin for the current drive and asking for confirmation before deleting is turned on. Close the dialog
3. Select 1 or more files (no folders)
4. Drag the file(s) on the F8 Delete button
   A confirmation dialog pops up.

There is a no confirmation dialog when deleting files directly:

1. Right-click the F8 Delete button and select Properties
2. Make sure deleted files are deleted directly (not moved to recycle bin) for the current drive and asking for confirmation before deleting is turned on. Close the dialog
3. Select 1 or more files (no folders)
4. Drag the file(s) on the F8 Delete button
   No confirmation dialog is shown and the file(s) are gone.

This issue was introduced in TC version 9.0 when various improvements were made to the delete function.

[ghisler(Author)]

Postponed to beta 3.

[ghisler(Author)]

Not confirmed with fresh ini.

[white]

Tested with fresh ini on Windows 11 23H2.
Tested with new installation on Windows Sandbox (Windows 11 22H2).
Tested with fresh ini on a Windows 10 virtual machine.

You said postponed it to beta 3. Does that mean you could reproduce it before?

Can anyone else reproduce it?

[ghisler(Author)]

I have just re-checked it - the confirmation comes from Windows itself when you enable it in recycle bin, not from Total Commander. If you don't want a confirmation there, you would also have to disable it in recycle bin itself.

[white]

If you don't want a confirmation there, you would also have to disable it in recycle bin itself.

I do want it, but TC causes the Windows confirmation not to be shown when using TC version 9.0 or above.

[ghisler(Author)]

I do want it, but TC causes the Windows confirmation not to be shown when using TC version 9.0 or above.

I don't understand, wouldn't this be the idea of disabling the confirmation in recycle bin itself?

[white]

I don't understand, wouldn't this be the idea of disabling the confirmation in recycle bin itself?

I added red color in the first post to indicate the behavior I do not expect. And I changed the bulleted lists to numbered lists. I don't understand your comment. The Window confirmation of the recycle bin itself is turned on in step 2:

Make sure .. and asking for confirmation before deleting is turned on.

Do you mean something else?

[ghisler(Author)]

I have checked my code - the delete function explicitly checks for the MouseActions registry value, and doesn't show a confirmation if it's set, so this seems to be intentional. I'm sure that a lot of people would complain if I changed it now.

[white]

I have checked my code - the delete function explicitly checks for the MouseActions registry value, and doesn't show a confirmation if it's set, so this seems to be intentional. I'm sure that a lot of people would complain if I changed it now.

I don't think it was intentional. The Windows confirmation is shown when moving to recycle bin (so when the files are not lost), but not when deleting files directly. Perhaps you intended to bypass the confirmation when moving to recycle bin, but now it is the other way around which does not make sense.

You were always very careful with deletions. You did not allow for no confirmation before deletion. But since TC 9 there is a dangerous situation. The configuration option "Drag&Drop (copying file with mouse)" does not mention deletion by dropping on the F8 button. There is a high chance that people are totally unaware that someone bumping into them or a cat doing something unexpected while the person is dragging a bunch of files around may end up in losing the files. Or that while meaning to drag files outside of the TC window, twitching of the finger muscles or a faulty mouse can result in directly deleting files without confirmation. It can cause a lot of confusion when people don't understand why their files are suddenly gone.

I had also checked the HISTORY.TXT file and I noticed there were several technical improvements made to the delete function. But, nothing about intentionally suppressing the Windows confirmation when deleting files directly. You would think you would have added something to HISTORY.TXT about it. It also does not make sense that you would have implemented this while not making this optional. And it doesn't make sense that you wouldn't have changed the text of the option to also mention deletion and that you wouldn't have added something about it to the help page.

Now people should be made aware of this. Perhaps you can change it so the Windows confirmation is suppressed when files are moved to recycle bin and not when they are deleted directly. And if you want to build in support for the people who gotten used to be able to delete files directly without confirmation, you could add an ini option for explicitly allowing that.

[ghisler(Author)]

Sorry but people would really complain a lot if I changed that now after so many years.

[white]

Sorry but people would really complain a lot if I changed that now after so many years.

How many people are even aware that you can drop files on the "F8 Delete" button? If you keep it as it is, you should at least change the text of the option from "Drag&Drop (copying files with mouse)" to for example "Drag&Drop (copying/deleting files with mouse)". And explain it properly in the help with a warning that this is risky.

And as said, you could make it optional and make the default either way, or change the default for new installations only.

And if you consider suppressing the Windows confirmation by design, it should also be suppressed when files are moved to recycle bin.

[JOUBE]

Sorry but people would really complain a lot if I changed that now after so many years.

Yes, please do not change it. It is important, thats not changed. Thanks.

Many, many things have changed in the last time, without real needs, based on requests from people, without the use of Tc over the years.

[ghisler(Author)]

Moderator message from: ghisler(Author) » 2024-10-27, 09:15 UTC

Moved to will not be changed

[white]

2ghisler(Author)
I see you've moved this to "TC behavior that will not be changed". Can you explain the reasoning behind suppressing the Windows confirmation when files are deleted directly, but not when files are moved to the recycle bin?

Can you also explain why it is not important to inform people that disabling the confirmation not only applies to copying (as the user interface says), and not only to copying and moving (as the help says), but also to deleting files?