[TC 11.50b3] Compare by Content: Abort during binary compare

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
white
Power Member
Power Member
Posts: 5964
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

[TC 11.50b3] Compare by Content: Abort during binary compare

Post by *white »

Compare by content 2 large files.

When using a text compare (Binary not checked), the comparing can be aborted by all the methods you can use to close the window (Esc, Alt+F4, X button) and the Abort button. When comparing is aborted a message box is displayed saying: "User abort!".

When using binary mode to compare the files, you can only use Esc to abort the comparison. I can understand if this is done for speed reasons. What I don't understand is that the Compare button changes into an Abort button you cannot use (although it has the enabled state). If you cannot use the Abort button, I think it would be good to not change the Compare button into an Abort button, but instead disable the Compare button during the comparison. Furthermore, when you abort the comparison by pressing Esc, it aborts quietly without a message box saying: "Use Abort!". This seems inconsistent and confusing.

The help text does not mention an Abort button, nor any information about aborting.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50817
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.50b3] Compare by Content: Abort during binary compare

Post by *ghisler(Author) »

I have tested it now - you can abort via button during the compare phase, e.g. when the first difference is near the end of the files. However, you can only abort with ESC during the phase where the tool counts the number of differences. I will fix that.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 5964
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.50b3] Compare by Content: Abort during binary compare

Post by *white »

ghisler(Author) wrote: 2024-10-29, 10:02 UTC - you can abort via button during the compare phase, e.g. when the first difference is near the end of the files. However, you can only abort with ESC during the phase where the tool counts the number of differences.
I compared 2 files using binary compare of sizes 2.787.952.934 bytes and 1.054.274.743 bytes. I can follow the progress in the status bar. When I press Esc, the progress indicators in the status bar freezes and then (after a variable pause) the status bar becomes empty.

If I click Abort the progress in the status bar keeps going till the end and then the number of differences are shown. If I don't abort, it says:
5 differences found

If I clicked abort, it says higher numbers like:
22 differences found
24 differences found
27 differences found
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50817
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.50b3] Compare by Content: Abort during binary compare

Post by *ghisler(Author) »

That's the phase where the tool looks for the number of differences. It starts immediately because the 2 files have different sizes, so they can't be idential.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 5964
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.50b3] Compare by Content: Abort during binary compare

Post by *white »

HISTORY.TXT wrote: 25.10.24 Fixed: Compare by content, binary mode: The search for the number of differences could only be aborted via ESC, not via button (32/64)
Tested OK using TC 11.50b4 32-bit and 64-bit.

Moderator message from: white » 2024-10-30, 17:15 UTC

Moved topic
» from TC11.x bug reports (English) to TC Fixed bugs
Post Reply