Unexpected redraw and delayed response to action & unexpected behavior

Moderators: Hacker, petermad, Stefan2, white

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50934
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Unexpected redraw and delayed response to action & unexpected behavior

Post by *ghisler(Author) »

I have compiled your code, yes. What makes the scrolling slow in my code is that for each line, I first have to load all the plugins, then all the fields for a specific plugin, and then all the operators and the values for that field. You seem to just swap the controls, but this mixes up the tab order.
Author of Total Commander
https://www.ghisler.com
User avatar
AntonyD
Power Member
Power Member
Posts: 1678
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: Unexpected redraw and delayed response to action & unexpected behavior

Post by *AntonyD »

It seems I really don't understand what is happening. What delay are we talking about - when I have exactly the opposite - I had only MOMENTARY usage of this object, unlike your code that is currently running in Total? WHAT exactly is suddenly happening to you that is slower??? I don't understand how this is even possible....

As for TAB-navigating through objects - I didn't have the goal to implement this feature in this project. The main goal was to show HOW quickly the process of adding rules can work, HOW quickly rules can be moved by priority, how intuitively the current active line can be highlighted. How convenient it is to delete rules with a special button next to the rule. THESE are all the goals that this code was supposed to demonstrate.
#146217 personal license
User avatar
white
Power Member
Power Member
Posts: 6022
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: Unexpected redraw and delayed response to action & unexpected behavior

Post by *white »

AntonyD wrote: 2025-06-15, 10:54 UTC It seems I really don't understand what is happening. What delay are we talking about - ....
I think Ghisler simply explained why his current code (without using your code) is slow.
AntonyD wrote: 2025-06-15, 10:54 UTC As for TAB-navigating through objects - I didn't have the goal to implement this feature in this project. ...
Fixing the tab order does indeed seem like a fixable thing.
User avatar
AntonyD
Power Member
Power Member
Posts: 1678
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: Unexpected redraw and delayed response to action & unexpected behavior

Post by *AntonyD »

I have some thoughts about this. So it looks likes pretty doable thing.
BUT again - FIRST OF ALL - I wanted to try speed up significantly any draw operations...
#146217 personal license
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50934
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Unexpected redraw and delayed response to action & unexpected behavior

Post by *ghisler(Author) »

I think Ghisler simply explained why his current code (without using your code) is slow.
Correct. However, I think that with the latest changes the current implementation is fast enough to be usable. I will consider changing to swapping just the lines in a later version, but this could cause all kinds of new problems (just like the mixed up tab order). Changing the tab order now would delay the release by another few weeks.
Author of Total Commander
https://www.ghisler.com
User avatar
AntonyD
Power Member
Power Member
Posts: 1678
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: Unexpected redraw and delayed response to action & unexpected behavior

Post by *AntonyD »

Of course, we are not talking about the current release for this task. This is clear))))

But besides just swapping the positions of the lines, I will repeat - there are other aspects that are MORE convenient and useful for the user: highlighting the ROW with the rule, not just its clarification by the dashed line of the active object inside this row with a rule
(and if the cursor is in the edit box - then only the thinnest color outline of its borders shows the current rule - which is very inconvenient).
And of course, having a delete button directly next to the rule - This in total is the reason for changing the code and presenting all this
as a significant improvement in container usability. imho.
#146217 personal license
User avatar
petermad
Power Member
Power Member
Posts: 16157
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Unexpected redraw and delayed response to action & unexpected behavior

Post by *petermad »

Now that the sort buttons are moved out under the Help button there is no need that their height is so low: https://tcmd.madsenworld.dk/findfilespluginssortbuttons.png

I would like to see them in the same size as in the View Mode configuration dialog: https://tcmd.madsenworld.dk/viewmodesortbuttons.png

It would also look nicer if the buttons in the Find files dialog would be placed a little further down from the button above it - again like in the View Mode configuration dialog.
License #524 (1994)
Danish Total Commander Translator
TC 11.55rc4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1393a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50934
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Unexpected redraw and delayed response to action & unexpected behavior

Post by *ghisler(Author) »

I would like to see them in the same size as in the View Mode configuration dialog
OK, I will change that.
It would also look nicer if the buttons in the Find files dialog would be placed a little further down from the button above it
It seems to be off in 64-bit only, I will check it.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 16157
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Unexpected redraw and delayed response to action & unexpected behavior

Post by *petermad »

It seems to be off in 64-bit only
Confirmed.
License #524 (1994)
Danish Total Commander Translator
TC 11.55rc4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1393a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50934
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Unexpected redraw and delayed response to action & unexpected behavior

Post by *ghisler(Author) »

I have enlarged the sorting buttons in Total Commander 11.55 final, please check it!
Author of Total Commander
https://www.ghisler.com
User avatar
AntonyD
Power Member
Power Member
Posts: 1678
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: Unexpected redraw and delayed response to action & unexpected behavior

Post by *AntonyD »

please check it!
Confirm! That was done. And that's super.
BUT also by occasionally you've put this element on a first tab "General"!
https://i.ibb.co/TMFB3HSD/2025-06-25-155411.png
32+64 bit/ Dark/Light theme.
#146217 personal license
User avatar
tuska
Power Member
Power Member
Posts: 4132
Joined: 2007-05-21, 12:17 UTC

Re: Unexpected redraw and delayed response to action & unexpected behavior

Post by *tuska »

AntonyD wrote: 2025-06-25, 12:57 UTC BUT also by occasionally you've put this element on a first tab "General"!
https://i.ibb.co/TMFB3HSD/2025-06-25-155411.png
32+64 bit/ Dark/Light theme.
Just a comment:
After clicking on one of the following tabs, the 'sort button' on the “General” tab will be removed/hidden.
The ‘sort button’ only reappears when a new search window is opened.
User avatar
petermad
Power Member
Power Member
Posts: 16157
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Unexpected redraw and delayed response to action & unexpected behavior

Post by *petermad »

history.txt wrote:22.06.25 Fixed: Find files, Plugins tab: The sorting buttons now have the same height as in the View Mode configuration dialog (32/64)
Well not here:
in Windows 7 (Aero theme) and Windows 10 the buttons are two pixels lower in the plugins dialog: https://tcmd.madsenworld.dk/scrollbuttons1155W7.png and https://tcmd.madsenworld.dk/scrollbuttons1155W10.png

In Windows 7 the buttom border is cut off from the buttom button.

It is the same in 32bit and 64bit TC.
License #524 (1994)
Danish Total Commander Translator
TC 11.55rc4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1393a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
tuska
Power Member
Power Member
Posts: 4132
Joined: 2007-05-21, 12:17 UTC

Re: Unexpected redraw and delayed response to action & unexpected behavior

Post by *tuska »

HISTORY.TXT wrote:25.06.25 Release Total Commander 11.55 official release
22.06.25 Fixed: Find files, Plugins tab: The sorting buttons now have the same height as in the View Mode configuration dialog (32/64)
Total Commander 11.55 - Size of the “Sort” buttons

Code: Select all

Size	   (x64)	(x86)	   Title
-----------------------------------------------------
Width      29 px  	29 px	   ) Find Files:
Height     35 px  	36 px 	   ) Plugins tab
-----------------------------------------------------
Width      26 px 	28 px	   ) View mode
Height     37 px 	39 px	   ) Configuration
-----------------------------------------------------
Width      26 px 	28 px	   ) Auto Switch Mode
Height     37 px 	38 px	   ) Configuration
-----------------------------------------------------
⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺
Tested with:
TC 11.55 x64/x86 Normal- and dark mode | Windows 11 Pro (x64) Version 24H2 (OS build 26100.4351) - 2025-06-11
Monitor 24'', Scaling size 125%, resolution 1920 x 1280 pixel (native screen resolution)

TC - Configuration > Options... > Font: Segoe UI,9 > Dialog box scaling (does not scale the main window):
✅ Set dots per inch (DPI) to: 120 > ✅ Automatically adjust dialog boxes to larger fonts

FastStone Capture version 11.0 - Screen Ruler | Screen Size (Diagonal Length): 24.0 inch | PPI (Pixels Per Inch): 94.3
The dimensions on the screen, measured with the on-screen ruler in FastStone Capture, correspond to a scale of 1:1.
⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺⸺
EDIT: Added...
With these settings, the “Configuration” window in Total Commander will have the following dimensions:
23.5 cm width and 17.9 cm height.
Last edited by tuska on 2025-06-26, 11:50 UTC, edited 1 time in total.
User avatar
white
Power Member
Power Member
Posts: 6022
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: Unexpected redraw and delayed response to action & unexpected behavior

Post by *white »

tuska wrote: 2025-06-25, 13:52 UTC After clicking on one of the following tabs, the 'sort button' on the “General” tab will be removed/hidden.
The ‘sort button’ only reappears when a new search window is opened.
Confirmed.
Post Reply