TC 7.50 - IViewAdditionalTypes length bug

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
fenix_productions
Power Member
Power Member
Posts: 1979
Joined: 2005-08-07, 13:23 UTC
Location: Poland
Contact:

TC 7.50 - IViewAdditionalTypes length bug

Post by *fenix_productions »

Steps to reproduce:

1. install SynPlus plugin,
2. check if it works correctly for text files (i.e. cpp),
3. open your wincmd.ini,
4. go to [Lister] section,
5. make sure that IViewAdditionalTypes parameter value exceedes total length of 259 characters,
6. save configuration file and restart your TC,
7. try to preview text files via F3.

Plugin will not be loaded and file's content will be shown using lister only.

IMHO SynPlus should be loaded without any problems.

Notes:
I can reproduce such behaviour with any beta version of 7.50 (even private ones) but not with 7.04a.
Last edited by fenix_productions on 2009-08-17, 23:36 UTC, edited 1 time in total.
"When we created the poke, we thought it would be cool to have a feature without any specific purpose." Facebook...

#128099
Postkutscher
Power Member
Power Member
Posts: 556
Joined: 2006-04-01, 00:11 UTC

Post by *Postkutscher »

2fenix_productions
Could you please publish your IViewAdditionalTypes= string here to make us retesting simplier?

[added]
I cannot confirm this issue. What detectstring have you for SynPlus? I don`t have any.
User avatar
fenix_productions
Power Member
Power Member
Posts: 1979
Joined: 2005-08-07, 13:23 UTC
Location: Poland
Contact:

Post by *fenix_productions »

2Postkutscher

Parameter:

Code: Select all

IViewAdditionalTypes=*.!S *.$C *.$S *.001 *.16 *.2BP *.2D *.301 *.411 *.4BIT *.4BT *.73I *.82I *.83I *.85I *.86I *.89I *.92I *.RAW *.A64 *.ABS *.ACE *.ACR *.AFX *.AI *.ALIAS *.ALS *.AMI *.ANV *.APX *.ARF *.ARN *.ART *.ATK *.ATT *.AVS *.AWD *.B&W *.B16 *.B3D *.B_W *.BFL *.BFLI *.BFX *.BGA *.BIE *.BIF *.BIG *.BLD *.BLK *.BMC *.BMF *.BMS *.BOB *.BPX *.BRK *.BRT *.BS *.BTN *.BUM *.C4 *.CAL *.CALS *.CAM *.CAN *.CAR *.CAT *.CBM *.CDU *.CE1 *.CE2 *.CFT *.CIN *.CIT *.CLO *.CLOE *.CMP *.CMT *.CMU *.CP8 *.CPI *.CPT *.CRG *.CRW *.CT *.CURSOR *.CUT *.CVP *.DAT *.DCM *.DIS *.DJV *.DJVU *.DOO *.DPX *.DRZ *.ECC *.ECW *.EI *.EIDI *.EIF *.EPA *.EPI *.ERI *.ESM *.FAC *.FACE *.FAX *.FBM *.FFF *.FI *.FIF *.FIT *.FITS *.FPG *.FPX *.FRE *.FRM *.FSH *.FSY *.FTS *.FXO *.FXS *.G3 *.G3N *.G4 *.GAF *.GBR *.GEM *.GEO *.GG *.GIFF *.GL2 *.GM2 *.GM4 *.GRB *.GREY *.GRO *.GRY *.HDR *.HDRU *.HED *.HF *.HG *.HGL *.HIR *.HP *.HP1 *.HP2 *.HPG *.HPGL *.HPGL2 *.HPI *.HR *.HRU *.HRZ *.HTA *.I17 *.I18 *.IB7 *.ICA *.ICB *.ICN *.ICO *.ICON *.IDC *.IF9 *.IIM *.IIMG *.ILBM *.IM *.IM5 *.IMA *.IMG *.IMT *.INFO *.IOCA *.IPG *.IPH *.IPT *.IRIS *.ISH *.ISM *.ISS *.ITG *.IVB *.IW4 *.IWC *.J2K *.J6I *.JBF *.JBG *.JBIG *.JFIF *.JIF *.JJ *.JLS *.JNG *.JP2 *.JPC *.JPS *.JPX *.JTF *.K25 *.KDC *.KFX *.KOA *.KPS *.KQP *.LDA *.LFF *.LIF *.LVP *.LWI *.M8 *.MAG *.MAP *.MBFAVS *.MBFS *.MBM *.MDL *.MGR *.MIF *.MIFF *.MIL *.MPNT *.MRF *.MSK *.MSP *.MTV *.MTX *.NCD *.NCR *.NCT *.NEF *.NEO *.NGG *.NITF *.NLM *.NOL *.NPM *.OAZ *.OCP *.OFX *.OIL *.OTB *.P2 *.P64 *.P7 *.PAC *.PAINT *.PAN *.PBT *.PC1 *.PC2 *.PC3 *.PCC *.PCL *.PCT *.PD *.PDB *.PDD *.PDS *.PDX *.PE4 *.PFR *.PGC *.PGF *.PHP *.PI1 *.PI2 *.PI3 *.PI4 *.PI5 *.PI6 *.PICIO *.PICT *.PICT2 *.PIG *.PIX *.PIXAR *.PLO *.PLT *.PMG *.PMP *.PNM *.PNT *.PNTG *.PP4 *.PP5 *.PPM *.PPP *.PPS *.PPT *.PRC *.PRF *.PRI *.PRN *.PSE *.PSF *.PSP *.PST *.PWC *.PWP *.PXA *.PXB *.PXR *.PXS *.PZL *.PZP *.Q0 *.QDV *.QRT *.QTI *.QTIF *.QTL *.RAD *.RAST *.RGBA *.RGH *.RIX *.RL4 *.RL8 *.RLB *.RLC *.RPBM *.RPGM *.RPNM *.RPPM *.RS *.RSB *.SAR *.SC2 *.SC? *.SCI *.SCR *.SCT *.SCX *.SD0 *.SD1 *.SD2 *.SDG *.SDT *.SEQ *.SFF *.SFW *.SI *.SID *.SIM *.SIR *.SJ1 *.SKF *.SKN *.SKP *.SMP *.SNA *.SPC *.SPL *.SPS *.SPU *.SR *.SSI *.SSP *.ST4 *.ST5 *.ST6 *.ST7 *.ST8 *.STM *.STW *.STX *.SUL *.SUN *.SUNIFF *.SYN *.SYNU *.SYS *.T1 *.T2 *.TAAC *.TAP *.TARGA *.TDI *.TDIM *.TEX *.TG4 *.THB *.TIL *.TILE *.TIM *.TN1 *.TN2 *.TN3 *.TNL *.TNY *.TTF *.TUB *.UPI *.URT *.UYVY *.VDA *.VFF *.VGA *.VI *.VIC *.VICAR *.VID *.VIF *.VIFF *.VIT *.VPB *.VST *.WAD *.WAL *.WBC *.WBZ *.WFX *.WIC *.WLM *.WPG *.WRL *.X11 *.XAR *.XIF *.XIM *.XP0 *.XV *.XWD *.YPC *.YUV *.ZBR *.ZMF
Postkutscher wrote: I cannot confirm this issue. What detectstring have you for SynPlus? I don`t have any.
I can reproduce it every time with no detect string at all but you might try the first one I had when I discovered this bug:

Code: Select all

27_detect="([0]!="M" | [1]!="Z") | ([0]!="P" | [1]!="K") | EXT!="RTF""
"When we created the poke, we thought it would be cool to have a feature without any specific purpose." Facebook...

#128099
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50840
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

IViewAdditionalTypes is limited to 259 characters, this hasn't been changed in TC 7.5. Since TC is in RC state now, I will better not change it because it can have many side effects.
Author of Total Commander
https://www.ghisler.com
User avatar
fenix_productions
Power Member
Power Member
Posts: 1979
Joined: 2005-08-07, 13:23 UTC
Location: Poland
Contact:

Post by *fenix_productions »

2ghisler(Author)
I know about this limit and I don't propose to extend it but to check (and fix) a bug with not loading SynPlus when it is too large.
"When we created the poke, we thought it would be cool to have a feature without any specific purpose." Facebook...

#128099
Postkutscher
Power Member
Power Member
Posts: 556
Joined: 2006-04-01, 00:11 UTC

Post by *Postkutscher »

2fenix_productions
I have just retested this issue with your parameter, but unfortunately still cannot reproduce it neither under WinXP, nor under Win7, neither with TC7.5PB8 , nor with TC7.5RC1. SynPlus is always loaded for *.cpp . Sorry, another factor must exist, which have an influence on this. :( The only thing I have not done, is to test this issue, when environment variables and spaces in the paths are used. I have short english paths.
User avatar
fenix_productions
Power Member
Power Member
Posts: 1979
Joined: 2005-08-07, 13:23 UTC
Location: Poland
Contact:

Post by *fenix_productions »

2Postkutscher
I think that there might be something else responsible for it but I don't know what. I don't remember this happening before 7.5 but I can reproduce that every time on two different Win XP machines now. Well, I can cut these entries a little bit :)

I just wonder what does happen when length is exceeded. Is there "a room" for any bug?
"When we created the poke, we thought it would be cool to have a feature without any specific purpose." Facebook...

#128099
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50840
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

The problem was the following: The string was cut at 510 characters (not 259), and in the middle of an extension - so the last extension was actually *.c !

I will change that so TC always cuts at the last space or semicolon if the string reaches the maximum length.
Author of Total Commander
https://www.ghisler.com
User avatar
fenix_productions
Power Member
Power Member
Posts: 1979
Joined: 2005-08-07, 13:23 UTC
Location: Poland
Contact:

Post by *fenix_productions »

2ghisler(Author)
Thank you for checking it.
"When we created the poke, we thought it would be cool to have a feature without any specific purpose." Facebook...

#128099
User avatar
fenix_productions
Power Member
Power Member
Posts: 1979
Joined: 2005-08-07, 13:23 UTC
Location: Poland
Contact:

Post by *fenix_productions »

TC7.50RC2: seems to be fixed.
"When we created the poke, we thought it would be cool to have a feature without any specific purpose." Facebook...

#128099
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50840
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks! Btw, I have also increased the max. length to ~1024 characters.
Author of Total Commander
https://www.ghisler.com
User avatar
fenix_productions
Power Member
Power Member
Posts: 1979
Joined: 2005-08-07, 13:23 UTC
Location: Poland
Contact:

Post by *fenix_productions »

ghisler(Author) wrote:Thanks! Btw, I have also increased the max. length to ~1024 characters.
This is definitely great news. Thank you very much.

P.S. Now the only limit which bothers me is the search filter length but this can wait after TC 7.5 and then be fixed together with my other report for Internal Associations :)
"When we created the poke, we thought it would be cool to have a feature without any specific purpose." Facebook...

#128099
Postkutscher
Power Member
Power Member
Posts: 556
Joined: 2006-04-01, 00:11 UTC

Post by *Postkutscher »

ghisler(Author) wrote:Thanks! Btw, I have also increased the max. length to ~1024 characters.
Nice. Thank you very much!
Post Reply