`Move` (F6) within the same volume should always be completed instantly

Here you can propose new features, make suggestions etc.

Moderators: white, Hacker, petermad, Stefan2

jb
Senior Member
Senior Member
Posts: 412
Joined: 2003-02-09, 22:56 UTC
Location: Switzerland

`Move` (F6) within the same volume should always be completed instantly

Post by *jb »

Sometimes it happens that a `Move` (F6) operation within the same volume is not completed instantly.
Instead TC starts copying and deleting like mad as if source and destination were on different volumes.
This seems to happen when the source is locked (partially), for example by TortoiseGit.
It would help if TC could inform the user in such cases before doing needless work.
User avatar
Dalai
Power Member
Power Member
Posts: 9461
Joined: 2005-01-28, 22:17 UTC
Location: Meiningen (Südthüringen)

Re: `Move` (F6) within the same volume should always be completed instantly

Post by *Dalai »

This is a long-standing issue and I think I made a suggestion about it many years ago that TC should show a confirmation where the user can choose whether to copy+delete the file(s) or cancel the operation. Can't find it right now, only my little rant about the annoyance that comes with it ;): https://www.ghisler.ch/board/viewtopic.php?p=332199#p332199

Regards
Dalai
#101164 Personal licence
Ryzen 5 2600, 16 GiB RAM, ASUS Prime X370-A, Win7 x64

Plugins: Services2, Startups, CertificateInfo, SignatureInfo, LineBreakInfo - Download-Mirror
User avatar
petermad
Power Member
Power Member
Posts: 14913
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: `Move` (F6) within the same volume should always be completed instantly

Post by *petermad »

If you have "Operation" -> "File comments" -> "Copy comments with files" that could account for some of the activity.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
jb
Senior Member
Senior Member
Posts: 412
Joined: 2003-02-09, 22:56 UTC
Location: Switzerland

Re: `Move` (F6) within the same volume should always be completed instantly

Post by *jb »

Dalai wrote: 2023-05-16, 21:55 UTC ... Can't find it right now, only my little rant about the annoyance that comes with it ;): https://www.ghisler.ch/board/viewtopic.php?p=332199#p332199
Indeed I'm getting annoyed about this behavior every now and then since years. After all it would be easier to accept, when somebody could explain, why it is hard to change. Is it caused by the Win32 API in the end? Seems unlikely to me.
jb
Senior Member
Senior Member
Posts: 412
Joined: 2003-02-09, 22:56 UTC
Location: Switzerland

Re: `Move` (F6) within the same volume should always be completed instantly

Post by *jb »

petermad wrote: 2023-05-16, 21:56 UTC If you have "Operation" -> "File comments" -> "Copy comments with files" that could account for some of the activity.
This option is disabled in my configuration. However, it should not matter when you move a directory within the same volume.
User avatar
funkymonk
Senior Member
Senior Member
Posts: 418
Joined: 2013-12-04, 09:56 UTC

Re: `Move` (F6) within the same volume should always be completed instantly

Post by *funkymonk »

Yes, it's truly annoying.
Sometimes it helps (or seems to help) to restart TC...
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48232
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: `Move` (F6) within the same volume should always be completed instantly

Post by *ghisler(Author) »

Sometimes it happens that a `Move` (F6) operation within the same volume is not completed instantly.
This should actually be fixed since Total Commander 11 beta 1: It happened when you confirmed the F6 dialog while TC was still counting files. That prevented the direct move of the directory. The beta now stops the counting thread and wait until it's closed before it tries to move the directory, so the error should no longer occur.
Author of Total Commander
https://www.ghisler.com
jb
Senior Member
Senior Member
Posts: 412
Joined: 2003-02-09, 22:56 UTC
Location: Switzerland

Re: `Move` (F6) within the same volume should always be completed instantly

Post by *jb »

ghisler(Author) wrote: 2023-05-18, 06:53 UTC This should actually be fixed since Total Commander 11 beta 1: It happened when you confirmed the F6 dialog while TC was still counting files. That prevented the direct move of the directory. The beta now stops the counting thread and wait until it's closed before it tries to move the directory, so the error should no longer occur.
What is supposed to happen after this correction when the source directory is partially locked?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48232
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: `Move` (F6) within the same volume should always be completed instantly

Post by *ghisler(Author) »

If something else locks the directory, TC will still copy the directory and then move the files and directories inside of it one by one.
My fix only addresses the case where TC itself was locking the directory.
Author of Total Commander
https://www.ghisler.com
JOUBE
Power Member
Power Member
Posts: 1507
Joined: 2004-07-08, 08:58 UTC

Re: `Move` (F6) within the same volume should always be completed instantly

Post by *JOUBE »

ghisler(Author) wrote: 2023-05-18, 06:53 UTC
Sometimes it happens that a `Move` (F6) operation within the same volume is not completed instantly.
This should actually be fixed since Total Commander 11 beta 1: It happened when you confirmed the F6 dialog while TC was still counting files. That prevented the direct move of the directory. The beta now stops the counting thread and wait until it's closed before it tries to move the directory, so the error should no longer occur.
This is a really important and useful improvement. Because that was really annoying: forgot to wait until the counting thread was over and it started miserably. *) Thanks for that!

Applications also often block a move and prevent a simple reassignment of a directory that was started from inside Tc while Tc was in this directory. For example the browser startet with an url file within Tc. (Lockhunter: the Browser (not the Tc itself) locks the folder).

Joube

*) Stop moving immediately, move back what you started, f6 again, wait this time until counting thread finished: move in tenths of a second...
jb
Senior Member
Senior Member
Posts: 412
Joined: 2003-02-09, 22:56 UTC
Location: Switzerland

Re: `Move` (F6) within the same volume should always be completed instantly

Post by *jb »

ghisler(Author) wrote: 2023-05-18, 13:26 UTC If something else locks the directory, TC will still copy the directory and then move the files and directories inside of it one by one.
My fix only addresses the case where TC itself was locking the directory.
Probably the fixed case occurred more frequently but the current behavior is very annoying regardless of the reason.
Would it be hard to fix also the other case and if yes why?
Note that my initial post addressed the other case (external lock) and suggested to give the user a choice before racing ahead.
An extra bonus would be to tell the user which processes are locking the directory to be moved.
User avatar
AntonyD
Power Member
Power Member
Posts: 1256
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: `Move` (F6) within the same volume should always be completed instantly

Post by *AntonyD »

An extra bonus would be to tell the user which processes are locking the directory to be moved.
Which is MOST DESIRABLE in this case, IMHO... and quite doable...
#146217 personal license
User avatar
Hacker
Moderator
Moderator
Posts: 13102
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Re: `Move` (F6) within the same volume should always be completed instantly

Post by *Hacker »

So, basically, implement the basic LockHunter functionality (list locking processes) in TC?

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
User avatar
AntonyD
Power Member
Power Member
Posts: 1256
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: `Move` (F6) within the same volume should always be completed instantly

Post by *AntonyD »

So, basically, implement the basic LockHunter functionality (list locking processes) in TC?
yep.
Have we got the basic functionality of the video-audio player in Lister ;)?
#146217 personal license
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48232
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: `Move` (F6) within the same volume should always be completed instantly

Post by *ghisler(Author) »

So, basically, implement the basic LockHunter functionality (list locking processes) in TC?
There is (to my knowledge) no official function to get this information, it's using undocumented Windows functions.
Last edited by white on 2023-05-19, 14:21 UTC, edited 1 time in total.
Reason: Fixed typo: to -> no
Author of Total Commander
https://www.ghisler.com
Post Reply