[TC 11.00b7] Context menu items does not respect file's avaialbility

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

User avatar
AntonyD
Power Member
Power Member
Posts: 1250
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

[TC 11.00b7] Context menu items does not respect file's avaialbility

Post by *AntonyD »

Open SyncDirs dialog for any non identical dirs - where obviously will be files existed only on left side - and only of right side.
Now choose such "single" file and call context menu. Items/Commands like 'Edit'/'Rename' - respect the fact of files availability
on sides of this dialog. So - IF file does exist on LEFT side ONLY - so commands 'Edit left'/'Rename left' - available for click on it.
And related commands 'Edit right'/'Rename right' - aren't available.
But command 'VIEW' and 'DELETE' - doesn't obey this fact. They ALSWAYS available.
https://ibb.co/Vgj9Mt8
there are no files on right side completely:
https://ibb.co/qdx3X9Z
#146217 personal license
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48166
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00b7] Context menu items does not respect file's avaialbility

Post by *ghisler(Author) »

View and delete are not new. Only rename is new.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14855
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00b7] Context menu items does not respect file's avaialbility

Post by *petermad »

I can confirm that the items:
"Copy file properties -> (left to right)...\tCtrl+Alt+L"
"Copy file properties <- (right to left)...\tCtrl+Alt+R"
"View left\tF3"
"View right\tShift+F3"
"<- Delete left"
"-> Delete right"

are not marked as in-applicable for single files.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
AntonyD
Power Member
Power Member
Posts: 1250
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [TC 11.00b7] Context menu items does not respect file's avaialbility

Post by *AntonyD »

2petermad
Thank you!
IMHO
"Compare left & right\tCtrl+F3"
+
"Delete on both sides"
these 2 commands also must be available only IF there are BOTH files on both sides exist.
#146217 personal license
User avatar
petermad
Power Member
Power Member
Posts: 14855
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00b7] Context menu items does not respect file's avaialbility

Post by *petermad »

"Compare left & right\tCtrl+F3"
+
"Delete on both sides"
these 2 commands also must be available only IF there are BOTH files on both sides exist.
I agree.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48166
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00b7] Context menu items does not respect file's avaialbility

Post by *ghisler(Author) »

OK, it turned out more complex than expected: The problem is that some of these commands work with multiple selected files.
View left/right: We must check whether any of the selected entries contains files or folders on the left/right
Delete left/right: We must check whether any of the selected entries contains files or folders on the left/right
Copy file properties from left to right/right to left: We must check whether any of the selected entries contains files on both sides
Reverse copy direction: We must check whether any of the selected entries contains files on both sides

Compare left & right will be kept enabled because it allows you to compare a single file with any other file by choosing it manually.
Author of Total Commander
https://www.ghisler.com
User avatar
AntonyD
Power Member
Power Member
Posts: 1250
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [TC 11.00b7] Context menu items does not respect file's avaialbility

Post by *AntonyD »

Probably in next version your answer will be more correct:
"Compare left & right will be kept enabled" + IF we choose + "to compare a single file with any other file" + "manually"
Because in case when I select only one row where - for example - on the left side there IS the file, but on right side there IS NO the file - this command can't do anything useful. So ONLY if we manually select TWO different lines with the same file on the oppositely-symmetric side, only then does it make sense to call this command.
#146217 personal license
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48166
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00b7] Context menu items does not respect file's avaialbility

Post by *ghisler(Author) »

Because in case when I select only one row where - for example - on the left side there IS the file, but on right side there IS NO the file - this command can't do anything useful.
That's not true. You get a warning that there is no file on the right, but then you can pick one with which you want to compare the left file.
Author of Total Commander
https://www.ghisler.com
User avatar
AntonyD
Power Member
Power Member
Posts: 1250
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [TC 11.00b7] Context menu items does not respect file's avaialbility

Post by *AntonyD »

You get a warning that there is no file on the right
only. So that's exactly what I called "can't do anything useful" ;)
It would be more straightforward and correct to activate this command only by selecting a pair of files from different sides.
because the very fact of separating the sides and the apparent inactivity of some menu items in itself suggests that something should be done about the selection of files in these panels.
#146217 personal license
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48166
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00b7] Context menu items does not respect file's avaialbility

Post by *ghisler(Author) »

But then you could not compare a single file on the left with a similarly named file on the right on another line!
Example:
Left is somecode.txt
Right is someoldercode.txt
You now want to see whether the two are the same or related, so you want to compare them before renaming someoldercode.txt to somecode.txt. how would you do this when compare would be disabled for somecode.txt?
Author of Total Commander
https://www.ghisler.com
User avatar
AntonyD
Power Member
Power Member
Posts: 1250
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [TC 11.00b7] Context menu items does not respect file's avaialbility

Post by *AntonyD »

We just check 2! two - states which are valuable for us.
IF selected only one row - and in it only one file on any side - disable command. Otherwise(each sides contain file) - enable it.
IF selected ONLY 2 - two rows - make second check for them: do they contain on different sides single files?
IF no - disable command. Otherwise(yes, they do) - enable it.
+ ALL other variants - disable command.
#146217 personal license
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48166
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00b7] Context menu items does not respect file's avaialbility

Post by *ghisler(Author) »

Sorry, I don't see the advantage. You will have one more disabled command, no smaller menu, and have to scroll to the end to find that second file you want to compare with.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14855
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00b7] Context menu items does not respect file's avaialbility

Post by *petermad »

2AntonyD
Because in case when I select only one row where - for example - on the left side there IS the file, but on right side there IS NO the file - this command can't do anything useful.
Yes it can - you can manually enter a file on the right side to compare with - just as if you in the ordinary file panel open "Compare contents" with none or one file selected, and there is NOT a file with the same name in the other panel.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
AntonyD
Power Member
Power Member
Posts: 1250
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [TC 11.00b7] Context menu items does not respect file's avaialbility

Post by *AntonyD »

2petermad
Not only did I not understand this - I cannot even imagine such a possibility - as relevant.
Once again - look at my view: https://ibb.co/WnJj3Lh
And you say that in SUCH position of the elements on the screen, I can enter at the top right
the full name till the file on a disk, so what?
Maybe it's better to show this "necessary" trick with manual data entry in the video?
#146217 personal license
User avatar
AntonyD
Power Member
Power Member
Posts: 1250
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [TC 11.00b7] Context menu items does not respect file's avaialbility

Post by *AntonyD »

2ghisler(Author)
and have to scroll to the end to find that second file you want to compare with.
I don’t understand this either - I SHOULD do this if for some reason in this dialog the necessary files were separated into subfolders and they didn’t meet directly and they had to be compared forcibly. Of course, I WILL look for the pair of files I need by scrolling through the list - there is nothing strange in this. This is expected. And it can't affect the visibility of the menu item in any way.
#146217 personal license
Post Reply