TC11.50B1: Lister (text): Inconsistency and "step change" of font size in Configure after text zoom

[Slavic]

Changing the text size by Ctrl+Wheel the same way as picture zoom is very good, but currently it has some problems with storing and changing the text size in the Lister configuration. After the text size was changed this way, the Configuration dialog shows the initial (previous) size, and attempt to change it using the standard Windows Font dialog shows the inconsistent size and results in "step increase" or decrease after each call of this dialog. Way to reproduce:

Initial configuration. Use the file HISTORY.TXT in the TC directory as UTF-8 text with ANSI charset, font in this test is Courier New, Regular, 12pt. These parameters are set in Configure Lister dialog. Font shown on the ANSI button is Courier New,-20,D120 - for my screen 1920x1080, scale 125%.
1. Open the file in Lister (F3) and use Ctrl+(Wheel forward), 3 clicks, which increases the font size by 3 steps.
2. Open configuration dialog. It still shows Courier New,-20,D120 on the ANSI button, as before. This ignores the change we just did.
3. Press the ANSI button. Windows Font dialog shows the font Courier New, Regular, 14pt. This is a real size after we zoomed the text by 3 clicks.
4. Press OK in Font dialog. Now the ANSI button shows Courier New,-23,D120, which is the parameter of current font. This is correct.
5. Press the ANSI button again. Font now is Courier New, Regular, 16pt. It looks increased, even though we didn't change it. Press OK.
6. ANSI button shows Courier New,-27,D120, which is obviously incorrect.
7. Repeatedly pressing the ANSI font button and OK in Font dialog, we continuously step-by-step increase (or decrease) the font size without actually changing anything.

How to fix (supposedly): font buttons in the Configure Lister dialog should show the current font size after any Ctrl+Wheel operation, consistently with Window Font dialog. Then pressing a button and closing Font by OK will keep current font parameters.

[ghisler(Author)]

2 is intentional, because the increase is temporary.
3 is also intentional, it should allow the user to save the new size
5 is not intentional, TC should reset the zoom factor to 1 but only does it too late. I will fix that.

[ghisler(Author)]

5 should be fixed in 11.50 beta 2, please check!

[Slavic]

Yes, the problem with step-by-step change is fixed in 11.50B2, thanks!

There still may be a small variation of font size after "OK" because applying current zoom factor not always gives the "standard" font sizes in points (which are shown in the Windows Font dialog), but the resulting increase/decrease is quite small and may not be taken into account. And Ctrl+0 works well.

[ghisler(Author)]

Thanks!

Moderator message from: ghisler(Author) » 2024-10-18, 13:45 UTC

Moved to fixed bugs