[TC 11.50b2] Inconsistency when 7-ZIP and LHA is chosen in the "Pack files" dialog

[petermad]

There is an Inconsistency when 7-ZIP is chosen in the "Pack files" dialog

The radio button for selecting 7-Zip is labelled 7-ZIP, but in the left side of the "Pack n file(s) to the archive" it says 7z: see: https://tcmd.madsenworld.dk/7z-7-zipaltf5.png

For ALL the other packers (including packer plugins) these two places show the same - that is why I think the 7-ZIP label should be changed to 7Z.

Also, for all packers except LHA the file extension is set to the same as the chosen item, but for LHA the extension is LZH - I suggest to change the LHA label to LZH https://tcmd.madsenworld.dk/lhalzhaltf5.png

[white]

There is an Inconsistency ..

Is there? A filename extension, a command word, and a packer name (or other reference to identify a packer) are different things. They don't necessarily have to be the same.

[petermad]

2white

As I wrote here: viewtopic.php?p=462098#p462098

if I prepend with 7-zip: I get a copy of the file, not a valid archive

So the label is misleading.

I agree that it is difficult because we deal with 3 different things: archive extension, packer name and as you call it: command words.

But for the external packers the packer name can be many things for the same archive extension - for example WinRAR.exe or RAR.exe for .rar archives, PKZip.exe or 7zG.exe for .zip archives etc. So I think it would be wise in the "Pack files" dialog only to go by archive extension and therefore change 7-ZIP to 7Z and LHA to LZH - then the labels corresponds both to the generated archive type and to the command word you use to prepend the archive name with in the "Pack n file(s) to the archive" field - this way we make the archive extension and the command word always the same and avoid dealing with packer names

[ghisler(Author)]

I will keep the 7z: prefix, but will also allow 7-zip: and 7zip: (lowercase, uppercase, mixed case) as prefix when entered manually.

[white]

But for the external packers the packer name can be many things for the same archive extension - for example WinRAR.exe or RAR.exe for .rar archives, PKZip.exe or 7zG.exe for .zip archives etc. So I think it would be wise in the "Pack files" dialog only to go by archive extension and therefore change 7-ZIP to 7Z and LHA to LZH - then the labels corresponds both to the generated archive type and to the command word you use to prepend the archive name with in the "Pack n file(s) to the archive" field - this way we make the archive extension and the command word always the same and avoid dealing with packer names

Agreed. Using filename extension as labels for the radio buttons would also be consistent with packer plugins, which are also listed by filename extension. Perhaps it is also better use lowercase and to include the dot (also for packer plugins). So use ".zip", ".7z, ".arj", etc. rather than "ZIP", "7Z, "ARJ", etc. Using lowercase makes it easier to read and distinguish. And adding the dot may make it more clear (or not, should be tested to see which looks better).

[petermad]

22.10.24 Added: Pack files (Alt+F5): Also accept prefixes 7zip: and 7-zip: in addition to 7z: to create 7-zip archives (32/64)

Confirmed fixed in TC 11.50b3 - but I still think packing labels should refer to archive file extension in "Pack files" dialog and the 3 packer Configuration dialogs

[ghisler(Author)]

Thanks for confirming the fix! The checkboxes have used "LHA" for years, I don't want to change it now, sorry.

Moderator message from: ghisler(Author) » 2024-10-24, 07:50 UTC

Moved to fixed bugs