[11.50b3] IconFromIcoFile does not seem to work

[Flint]

If I have ICO files associated for opening with some program, and the icon in the association is defined to something specific (not %1), then TC always displays this associated picture in the file lists for all the ICO files. It doesn't matter if I set IconFromIcoFile to 0 or to 1, the option seems to be ignored.

From the description in help/history I assumed that when IconFromIcoFile=1, TC should completely ignore the icon defined in the association, and load the image from the actual ICO file.

Tested in TC 10.50b3 32- and 64-bit, WIndows 10 x64.
For association I used MS Paint with the icon mspaint.exe,1. As soon as I return %1 to the associated icon option, all the icons are displayed with their own proper images.

[ghisler(Author)]

Do you have internal associations for .ico files? These take precedence over IconFromIcoFile=1 (which btw. is the default). IconFromIcoFile only overrides Windows associations. Can you confirm that?

[Flint]

No internal associations are present. This happens even when I start TC with empty INI.

[ghisler(Author)]

Not confirmed, will have to test again with a fresh ini. Could you provide the registry settings for .ico with registryinfo tool?
https://www.totalcommander.ch/win/tools/registryinfo.zip

[Flint]

Below is the archive with the following results:
1. Original state when I reverted virtual machine to when ICO files were not associated with anything.
2. After I associated ICO files with MS Paint using TC Associate With dialog. Notice that the default icon was automatically set to %1, so the icons were displayed properly, with the images loaded from the ICO files themselves.
3. Then I reopened Associate With dialog, and changed the icon for ICO files (Edit type, Change icon, C:\Windows\System32\mspaint.exe, selected the second icon). Closed all the dialogs with OK. After refreshing, all the ICO files are now displayed with the chosen icon from MS paint, regardless of whether IconFromIcoFile is set to 1 or 0, or just missing in the INI file.

• Archive with registryinfo dumps
• Screenshot of how it looks after step 3

[mihail_ms]

Добрый день. У меня тоже начинает отображать только после установки
SageThumbs.dll

При этом независимо от ключа IconFromIcoFile 1 или 0

Так же расширение должно иметь ассоциацию в системе с просмотрщиком фото(viewer,editor)

[Horst.Epp]

2mihail_ms
This forum is titled
TC 11.x Bug reports (English)

[ghisler(Author)]

Google translate gives me the following text:

Good day. For me it also starts displaying only after installing
SageThumbs.dll

In this case, regardless of the IconFromIcoFile key 1 or 0

Also, the extension must have an association in the system with the photo viewer (viewer, editor)

Strange, I do not have SageThumbs.dll on my system.

[mihail_ms]

Translate google
That's the mystery. If I understood correctly, now regardless of the system settings the icon should be shown from the file. Or not shown, as Total Commander is configured. In my case, at least 11.03, at least any beta, do not show icons as thumbnails (in full/short/comment mode), unless you do additional manipulations. For example, as I described above with Dll or establish an association with *.ico GreenfishIconEditor

origin
В том-то и загадка. Если я правильно понял, то теперь независимо от настроек системы значок должен показываться из файла. Или не показываться, как настроен Total Commander. В моем же случае хоть 11,03, хоть любая бета, не показывают иконки как эскизы(в режиме полный/краткий/комментарий) , если не делать доп манипуляций. Например как я описал выше с Dll или установить ассоциацию с *.ico GreenfishIconEditor

[ghisler(Author)]

With IconFromIcoFile=1, .ico files should always be shown with the icon inside of that file. With IconFromIcoFile=0, it depends on the file association. I modified the function a bit in beta 4 because it didn't work for some users, but I cannot reproduce the problem here. I will probably have to remove IconFromIcoFile from TC 11.50 and return to the behaviour of TC 11.03 if I can't find a solution.

[Flint]

2ghisler(Author)
Could you tell us more about your setup, how you are testing it? What OS version, what kind of association you're using (which program, which icon, which association method — via TC, or via Windows settings)?

I updated TC in my test VM to beta 4, but it didn't make any difference. Also I tried thumbnails view, and even in this mode there are no actual icons, only the associated icon is displayed (in large size).

P. S. I also tried in Win11 VM, but I could not assign a normal association to ICO files. Even via Windows Open As: I click "Choose an app on your PC", select IrfanView, confirm, but IrfanView does not appear in the list, and the association remains on the default Photos app. Either something is broken in my VM and it needs reinstalling, or Microsoft force-locked some associations…

[ghisler(Author)]

I have made a few more changes in beta 5, please test with that too! I still can't reproduce the error, so I don't know whether my changes have any effect or not.

[Flint]

Unfortunately, on my Win10 test machine nothing changed at all. The icons still show the MS Paint associated icon.

Interestingly enough, Vadim (my co-author) wrote to me, that beta 5 fixed the icons for him. So your change definitely affected something, but I'm not sure what the differences are between my and Vadim's systems.

[ghisler(Author)]

2Flint
In which case (from your archive ico-images.zip linked above) do you not get any icons from ico files?
ico-1-no-assoc.txt
ico-2-assoc.txt
ico-3-app-icon.txt

[Flint]

2ghisler(Author)
States 1 and 3 show incorrect icons.

In the state 1 the ICO files are not associated with anything from the point of view of TC, but they have icons small "Photos app". When I double-click them, the Photos app is opened and shows the icon.
Screenshot

The state 2 is after I set up the association with MS Paint. The icon is specified as %1 by default, and therefore they are displayed correctly.
Screenshot

The state 3 is after I changed the associated icon to a fixed MS Paint icon. Then the icons in file panels are displayed with that MS Paint icon.
Screenshot