Error sound after right click drive button

Bug reports will be moved here when the described bug has been fixed

Moderators: white, sheep, Hacker, Stefan2

User avatar
Usher
Member
Member
Posts: 129
Joined: 2011-03-11, 10:11 UTC

Error sound after right click drive button

Post by *Usher » 2018-06-10, 14:41 UTC

Steps to reproduce:
1. Turn on system sounds in windows and make sure TC uses sound for system error messages.
For example run TC as non-admin and try to open "C:\System Volume Info" folder. By default you should see TC message "Access denied…" and hear "Exclamation" sound (for system warning messages) and when you click "OK" or press Escape key, you will hear "Critical stop" sound (for system error messages).
2. Right click any column name (bug A) or tab header (bug B).
3. Right click any drive button. You will hear "Critical stop" sound with no error message visible.

Those bugs exists for a long time:
A) For column name - at least since TC 7.57a.
B) For tab header - starting from TC 9.0 b4. TC 9.0 b3 makes error sound only for sequence: right click column name, then right click drive button.

Tested only 32-bit versions TC on Windows XP.
Regards from Poland
Andrzej P. Wozniak

User avatar
Horst.Epp
Power Member
Power Member
Posts: 3111
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Re: Error sound after right click drive button

Post by *Horst.Epp » 2018-06-10, 15:02 UTC

Usher wrote:Steps to reproduce:
1. Turn on system sounds in windows and make sure TC uses sound for system error messages.
For example run TC as non-admin and try to open "C:\System Volume Info" folder. By default you should see TC message "Access denied…" and hear "Exclamation" sound (for system warning messages) and when you click "OK" or press Escape key, you will hear "Critical stop" sound (for system error messages).
2. Right click any column name (bug A) or tab header (bug B).
3. Right click any drive button. You will hear "Critical stop" sound with no error message visible.

Those bugs exists for a long time:
A) For column name - at least since TC 7.57a.
B) For tab header - starting from TC 9.0 b4. TC 9.0 b3 makes error sound only for sequence: right click column name, then right click drive button.

Tested only 32-bit versions TC on Windows XP.
Non of this bugs exists in the actual TC 9.20 b6 for x86 and x64
Tested on a real OS and not on unsupported XP.
Windows 10 Home x64 October 2018 Update
Version 1809 (OS Build 17763.134)
TC 9.21a x64 and x86, Everything 1.4.1.921 (x64)

User avatar
Gral
Power Member
Power Member
Posts: 665
Joined: 2005-01-26, 15:12 UTC

Re: Error sound after right click drive button

Post by *Gral » 2018-06-10, 18:49 UTC

Horst.Epp wrote:
Usher wrote:...Tested on a real OS and not on unsupported XP.
You're wrong!
Windows XP is supported!

User avatar
Horst.Epp
Power Member
Power Member
Posts: 3111
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Re: Error sound after right click drive button

Post by *Horst.Epp » 2018-06-10, 19:50 UTC

Gral wrote:
Horst.Epp wrote:
Usher wrote:...Tested on a real OS and not on unsupported XP.
You're wrong!
Windows XP is supported!
The only one which can support OS problems with XP is Microsoft.
Support for XP ended in April 2014, more than 4 years ago.
Windows 10 Home x64 October 2018 Update
Version 1809 (OS Build 17763.134)
TC 9.21a x64 and x86, Everything 1.4.1.921 (x64)

User avatar
Usher
Member
Member
Posts: 129
Joined: 2011-03-11, 10:11 UTC

Re: Error sound after right click drive button

Post by *Usher » 2018-06-10, 20:37 UTC

Horst.Epp wrote:Support for XP ended in April 2014, more than 4 years ago.
1. The problem for column name existed already in 2012, more than 6 years ago.
2. Windows XP SP3 in versions Embedded and POSReady 2009 will be supported until April 2019.
3. 32-bit TC version is supported for Windows starting from Windows 95, see download page: http://www.ghisler.com/download.htm
Regards from Poland
Andrzej P. Wozniak

User avatar
DrShark
Power Member
Power Member
Posts: 1113
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: Error sound after right click drive button

Post by *DrShark » 2018-06-10, 23:06 UTC

This post is offtopic, but I hope it will clear a bit current situation with Windows XP support in Total Commander.
Usher wrote:2. Windows XP SP3 in versions Embedded and POSReady 2009 will be supported until April 2019.
3. 32-bit TC version is supported for Windows starting from Windows 95, see download page: http://www.ghisler.com/download.htm
All true, but from what I know, Total Commander support for Win9x/2k/XP currently is in fact limited to:
* fixing of really critical bugs (even 16-bit TC for Windows 3.x will get fixes for serious bugs!);
* fixing of bugs that are obvious and is easy to fix, so such a fix will for sure work properly and won't introduce new bugs;
* fixing the bugs reproduced also on modern Windows (with current mainstream Microsoft support);
* support for new features that will obviously work correctly or can be tested by Christian Ghisler himself. For example, a button bar feature to use two asterisks in Command field to launch an app from different user works on Windows XP (confirmed by user here on a forum, and I can also confirm it works on XP 32-bit). But even though it in fact works in TC on Windows XP, officially it is supported only for Windows 7 and above (as stated on TC Help page Dialog box: Configuration - Change button bar; Vista is not mentioned too, but it really doesn't work there.) In 2017 I asked in email why this feature is not officially supported for WinXP, Christan Ghisler's answer was:
Christan Ghisler wrote:Since XP is out of support I will leave it as it is for now. I don't want to add the description if I don't know for sure that it works in all XP versions.
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
Usher
Member
Member
Posts: 129
Joined: 2011-03-11, 10:11 UTC

Post by *Usher » 2018-06-11, 00:45 UTC

@Horst.Epp
@DrShark

Do you think your rants about support are helpful or maybe you just love flame wars?

The discussion here is about bug reports.
Can you confirm my report on any Windows version other than Windows XP?
Have you tried to right click various elements of TC GUI in various program configurations?
How do you know what is wrong, if you haven't tested anything?

(Biased) opinions or (unfounded) guessing won't explain anything, so describe your actions and link to documents, if needed, please.
Regards from Poland
Andrzej P. Wozniak

User avatar
DrShark
Power Member
Power Member
Posts: 1113
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Post by *DrShark » 2018-06-11, 02:21 UTC

Usher wrote:Can you confirm my report on any Windows version other than Windows XP?
I tried this on TC 9.20 beta 6, Vista 32-bit now. I can confirm what you're describing about message and sounds for step 1 (BTW, here on Vista on try to access c:\System Volume Information\ "Access denied…" message is actually an elevation dialog with "OK" and "As Administrator" options), but for steps 2 and 3 I don't hear any sounds. Tried default and custom columns, normal and locked tabs, different drive buttons...

However, I noticed a difference when entering "System Volume Information" in c:\ in file panel (by mouse left doubleclick or keyboard Enter key) and by executing
cd "c:\System Volume Information"
from TC's command line: in second case there is no "Critical stop" sound after pressing OK button or Esc key in error dialog.
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
petermad
Power Member
Power Member
Posts: 8066
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad » 2018-06-11, 03:26 UTC

1. Turn on system sounds in windows and make sure TC uses sound for system error messages.
For example run TC as non-admin and try to open "C:\System Volume Info" folder. By default you should see TC message "Access denied…" and hear "Exclamation" sound (for system warning messages) and when you click "OK" or press Escape key, you will hear "Critical stop" sound (for system error messages).
2. Right click any column name (bug A) or tab header (bug B).
3. Right click any drive button. You will hear "Critical stop" sound with no error message visible.
I can confirm this for TC 9.12 (32bit) under Windows XP
I can also confirm it for TC 9.12 (32- and 64-bit) under Windows 8.1
I can also confirm it for TC 9.20b3 (32- and 64-bit) under Windows 10
I can also confirm it for TC 9.20b6 (32- and 64-bit) under Windows 7

So it does not matter whether TC supports Windows XP or not, since it is also present under all "modern" Windows versions.
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.92b1 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
Horst.Epp
Power Member
Power Member
Posts: 3111
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Post by *Horst.Epp » 2018-06-11, 06:43 UTC

Usher wrote:@Horst.Epp
@DrShark

Do you think your rants about support are helpful or maybe you just love flame wars?

The discussion here is about bug reports.
Can you confirm my report on any Windows version other than Windows XP?
Have you tried to right click various elements of TC GUI in various program configurations?
How do you know what is wrong, if you haven't tested anything?

(Biased) opinions or (unfounded) guessing won't explain anything, so describe your actions and link to documents, if needed, please.
As I said in my first answer, I can't confirm your error in actual x64 Windows 10
Windows 10 Home x64 October 2018 Update
Version 1809 (OS Build 17763.134)
TC 9.21a x64 and x86, Everything 1.4.1.921 (x64)

User avatar
DrShark
Power Member
Power Member
Posts: 1113
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Post by *DrShark » 2018-06-11, 07:36 UTC

After more tests I can confirm step 3 sound issue on Vista 32-bit.
Step 1 is not necessary to reproduce it: if drive bar enabled, there will be a "Critical stop" sound on a right click (context menu call) on any drive bar letter after right-clicking on a column or a tab.
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
petermad
Power Member
Power Member
Posts: 8066
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad » 2018-06-11, 11:59 UTC

I can't confirm your error in actual x64 Windows 10
Well, as I wrote in my previous post, I can confirm it also under Windows 10 x64.

Notice that after having right-clicked on a Column header or a Folder tab, you have to LEAVE the context menu OPEN and then right-click on a Drive button in order to reproduce the bug.

Under Windows XP, 7 and 8.1 it happens every time for me, but under Windows 10 it only happens 10-20% of the time, but I guess that could be due to my Window 10 PC being very slow.
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.92b1 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36511
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-06-11, 13:58 UTC

I havce tried it on XP 64-bit with both TC 32-bit and 64-bit, but I don't get any beeps in these cases. I do get a beep on Shift+Delete, though.
Author of Total Commander
http://www.ghisler.com

User avatar
Horst.Epp
Power Member
Power Member
Posts: 3111
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Post by *Horst.Epp » 2018-06-11, 14:03 UTC

petermad wrote:
I can't confirm your error in actual x64 Windows 10
Notice that after having right-clicked on a Column header or a Folder tab, you have to LEAVE the context menu OPEN and then right-click on a Drive button in order to reproduce the bug.
But who on earth leaves a context menu open
and then right clicks on some other GUI element ?
I guess with such procedures I will be able to find even more strange
errors with no relevance for normal operation.
Windows 10 Home x64 October 2018 Update
Version 1809 (OS Build 17763.134)
TC 9.21a x64 and x86, Everything 1.4.1.921 (x64)

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36511
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-06-11, 14:21 UTC

This is due to the following code:

Code: Select all

  if ShowRightclickMenuActive then begin
    MessageBeep(mb_iconexclamation);
    exit;
  end;
It should prevent the user from opening a context menu multiple times via cm_* commands.

It seems to be a specific XP behaviour that it sends the mouse command while the context menu is still open. On Windows 10, it seems to close the context menu first, and then send the mouse right click to TC.

The above code is important to avoid multiple menu calls, so I will not remove it.
Author of Total Commander
http://www.ghisler.com

Post Reply