This forum uses cookies. Click X button to hide this message. What is stored? / Privacy
Total Commander Forum Index Total Commander
Forum - Public Discussion and Support
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

*** Fixed: Files Find in several locations bug/issue

 
Post new topic   Reply to topic    Total Commander Forum Index -> TC Fixed bugs Printable version
View previous topic :: View next topic  
Author Message
Ovg
Power Member
Power Member


Joined: 06 Jan 2014
Posts: 532
Location: MOW

PostPosted: Mon Jun 11, 2018 11:18 am    Post subject: *** Fixed: Files Find in several locations bug/issue Reply with quote

If a first location in the list Search in doesn't exist - overall search failed, despite the other existing locations.

For example: I have saved search in d:\;h:\;i:\;j:\. all of them are usb flash drives. When drive d: doesn't exist, overall search is failed, while the rest drives are exist. I get "Search path not found" error message window[/b]
_________________
It's impossible to lead us astray for we don't care even to choose the way.
#259941, TC 9.20 RC1 x64, Windows 7 SP1 x64


Last edited by Ovg on Wed Jun 13, 2018 9:25 pm; edited 3 times in total
Back to top
View user's profile Send private message Send e-mail
MarcinW
Power Member
Power Member


Joined: 23 Jan 2012
Posts: 836
Location: Poland

PostPosted: Mon Jun 11, 2018 11:30 am    Post subject: Reply with quote

Confirmed. Assuming that drive "x:" doesn't exist:

- for search path c:\;x:\;d:\ TC searches properly in c:\ and d:\

- for search path x:\;c:\;d:\ TC gives up immediately and no search is performed.

Regards
Back to top
View user's profile Send private message Send e-mail
Ovg
Power Member
Power Member


Joined: 06 Jan 2014
Posts: 532
Location: MOW

PostPosted: Mon Jun 11, 2018 11:32 am    Post subject: Reply with quote

2MarcinW

Exactly! Thanks for testing!
_________________
It's impossible to lead us astray for we don't care even to choose the way.
#259941, TC 9.20 RC1 x64, Windows 7 SP1 x64
Back to top
View user's profile Send private message Send e-mail
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 35752
Location: Switzerland

PostPosted: Tue Jun 12, 2018 8:22 am    Post subject: Reply with quote

Indeed TC only checks the first path now, and gives an error when it's invalid. I agree that TC should also try the other paths. The downside is that you won't get any error when ALL paths are invalid.
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
Ovg
Power Member
Power Member


Joined: 06 Jan 2014
Posts: 532
Location: MOW

PostPosted: Tue Jun 12, 2018 9:50 am    Post subject: Reply with quote

I think that this is better than nothing (as is now)
_________________
It's impossible to lead us astray for we don't care even to choose the way.
#259941, TC 9.20 RC1 x64, Windows 7 SP1 x64
Back to top
View user's profile Send private message Send e-mail
Usher
Junior Member
Junior Member


Joined: 11 Mar 2011
Posts: 32

PostPosted: Tue Jun 12, 2018 10:38 am    Post subject: Reply with quote

ghisler(Author) wrote:
The downside is that you won't get any error when ALL paths are invalid.
You can change the message "No files found" to "No files found or some paths are invalid".

Edited: all -> some paths
_________________
Regards from Poland
Andrzej P. Wozniak


Last edited by Usher on Tue Jun 12, 2018 3:11 pm; edited 1 time in total
Back to top
View user's profile Send private message
Gral
Power Member
Power Member


Joined: 26 Jan 2005
Posts: 601

PostPosted: Tue Jun 12, 2018 12:14 pm    Post subject: Reply with quote

Another simple question, another 4 wasted years

"TC Behaviour which will not be changed"

https://www.ghisler.ch/board/viewtopic.php?t=40456
Back to top
View user's profile Send private message
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 35752
Location: Switzerland

PostPosted: Wed Jun 13, 2018 11:30 am    Post subject: Reply with quote

Well, it took me a few hours to come up with a better solution: TC will now show all the invalid paths (up to 20), and also show the number of errors.
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
Ovg
Power Member
Power Member


Joined: 06 Jan 2014
Posts: 532
Location: MOW

PostPosted: Wed Jun 13, 2018 11:35 am    Post subject: Reply with quote

2ghisler(Author)
Thank you so much, Christian!
_________________
It's impossible to lead us astray for we don't care even to choose the way.
#259941, TC 9.20 RC1 x64, Windows 7 SP1 x64
Back to top
View user's profile Send private message Send e-mail
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 35752
Location: Switzerland

PostPosted: Wed Jun 13, 2018 11:55 am    Post subject: Reply with quote

Please test it and let me know if there are any problems!
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
Ovg
Power Member
Power Member


Joined: 06 Jan 2014
Posts: 532
Location: MOW

PostPosted: Wed Jun 13, 2018 12:08 pm    Post subject: Reply with quote

2ghisler(Author)

Done!

Working fine now.
MANY THANKS Very Happy
_________________
It's impossible to lead us astray for we don't care even to choose the way.
#259941, TC 9.20 RC1 x64, Windows 7 SP1 x64
Back to top
View user's profile Send private message Send e-mail
MarcinW
Power Member
Power Member


Joined: 23 Jan 2012
Posts: 836
Location: Poland

PostPosted: Thu Jun 14, 2018 4:55 am    Post subject: Reply with quote

Fixed, thanks!
Back to top
View user's profile Send private message Send e-mail
petermad
Power Member
Power Member


Joined: 05 Feb 2003
Posts: 7794
Location: Valsted, Denmark

PostPosted: Thu Jun 14, 2018 7:31 am    Post subject: Reply with quote

Quote:
Please test it and let me know if there are any problems!

Apparantly it has the downside, that you get a: "Search path not found!" message when searching from inside archives!!
_________________
#524
Danish Total Commander Translator
TC 9.20rc1 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit. TC 2.91b3 on Android 6.0

Get Extended Total Commander Menus
Back to top
View user's profile Send private message Send e-mail Visit poster's website
MarcinW
Power Member
Power Member


Joined: 23 Jan 2012
Posts: 836
Location: Poland

PostPosted: Thu Jun 14, 2018 7:51 am    Post subject: Reply with quote

A separate bug report was created for the problem with archives: https://www.ghisler.ch/board/viewtopic.php?t=50123
Back to top
View user's profile Send private message Send e-mail
Display posts from previous:   
Post new topic   Reply to topic    Total Commander Forum Index -> TC Fixed bugs All times are GMT - 6 Hours
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Imprint/Impressum: This site is maintained by Ghisler Software GmbH
Privacy Policy | Datenschutzerklärung | Politique de Confidentialité

Using phpBB © phpBB Group