*** Fixed: Files Find in several locations bug/issue

Bug reports will be moved here when the described bug has been fixed

Moderators: white, sheep, Hacker, Stefan2

Post Reply
User avatar
Ovg
Power Member
Power Member
Posts: 555
Joined: 2014-01-06, 16:26 UTC
Location: MOW

*** Fixed: Files Find in several locations bug/issue

Post by *Ovg » 2018-06-11, 17:18 UTC

If a first location in the list Search in doesn't exist - overall search failed, despite the other existing locations.

For example: I have saved search in d:\;h:\;i:\;j:\. all of them are usb flash drives. When drive d: doesn't exist, overall search is failed, while the rest drives are exist. I get "Search path not found" error message window[/b]
Last edited by Ovg on 2018-06-14, 03:25 UTC, edited 3 times in total.
It's impossible to lead us astray for we don't care even to choose the way.
#259941, TC 9.21a x64, Windows 7 SP1 x64

User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW » 2018-06-11, 17:30 UTC

Confirmed. Assuming that drive "x:" doesn't exist:

- for search path c:\;x:\;d:\ TC searches properly in c:\ and d:\

- for search path x:\;c:\;d:\ TC gives up immediately and no search is performed.

Regards

User avatar
Ovg
Power Member
Power Member
Posts: 555
Joined: 2014-01-06, 16:26 UTC
Location: MOW

Post by *Ovg » 2018-06-11, 17:32 UTC

2MarcinW

Exactly! Thanks for testing!
It's impossible to lead us astray for we don't care even to choose the way.
#259941, TC 9.21a x64, Windows 7 SP1 x64

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36511
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-06-12, 14:22 UTC

Indeed TC only checks the first path now, and gives an error when it's invalid. I agree that TC should also try the other paths. The downside is that you won't get any error when ALL paths are invalid.
Author of Total Commander
http://www.ghisler.com

User avatar
Ovg
Power Member
Power Member
Posts: 555
Joined: 2014-01-06, 16:26 UTC
Location: MOW

Post by *Ovg » 2018-06-12, 15:50 UTC

I think that this is better than nothing (as is now)
It's impossible to lead us astray for we don't care even to choose the way.
#259941, TC 9.21a x64, Windows 7 SP1 x64

User avatar
Usher
Member
Member
Posts: 129
Joined: 2011-03-11, 10:11 UTC

Post by *Usher » 2018-06-12, 16:38 UTC

ghisler(Author) wrote:The downside is that you won't get any error when ALL paths are invalid.
You can change the message "No files found" to "No files found or some paths are invalid".

Edited: all -> some paths
Last edited by Usher on 2018-06-12, 21:11 UTC, edited 1 time in total.
Regards from Poland
Andrzej P. Wozniak

User avatar
Gral
Power Member
Power Member
Posts: 665
Joined: 2005-01-26, 15:12 UTC

Post by *Gral » 2018-06-12, 18:14 UTC

Another simple question, another 4 wasted years

"TC Behaviour which will not be changed"

https://www.ghisler.ch/board/viewtopic.php?t=40456

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36511
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-06-13, 17:30 UTC

Well, it took me a few hours to come up with a better solution: TC will now show all the invalid paths (up to 20), and also show the number of errors.
Author of Total Commander
http://www.ghisler.com

User avatar
Ovg
Power Member
Power Member
Posts: 555
Joined: 2014-01-06, 16:26 UTC
Location: MOW

Post by *Ovg » 2018-06-13, 17:35 UTC

2ghisler(Author)
Thank you so much, Christian!
It's impossible to lead us astray for we don't care even to choose the way.
#259941, TC 9.21a x64, Windows 7 SP1 x64

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36511
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-06-13, 17:55 UTC

Please test it and let me know if there are any problems!
Author of Total Commander
http://www.ghisler.com

User avatar
Ovg
Power Member
Power Member
Posts: 555
Joined: 2014-01-06, 16:26 UTC
Location: MOW

Post by *Ovg » 2018-06-13, 18:08 UTC

2ghisler(Author)

Done!

Working fine now.
MANY THANKS :D
It's impossible to lead us astray for we don't care even to choose the way.
#259941, TC 9.21a x64, Windows 7 SP1 x64

User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW » 2018-06-14, 10:55 UTC

Fixed, thanks!

User avatar
petermad
Power Member
Power Member
Posts: 8066
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad » 2018-06-14, 13:31 UTC

Please test it and let me know if there are any problems!
Apparantly it has the downside, that you get a: "Search path not found!" message when searching from inside archives!!
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.92b1 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW » 2018-06-14, 13:51 UTC

A separate bug report was created for the problem with archives: https://www.ghisler.ch/board/viewtopic.php?t=50123

Post Reply