%M works incorectly with slashes.

Bug reports will be moved here when the described bug has been fixed

Moderators: white, sheep, Hacker, Stefan2

Post Reply
User avatar
Gral
Power Member
Power Member
Posts: 665
Joined: 2005-01-26, 15:12 UTC

%M works incorectly with slashes.

Post by *Gral » 2018-06-14, 20:47 UTC

On all 9.20 versions "%M" works incorrectly with forward slash as a path separator e.g. on FTP, gets entire path with disk "letter" (respectively digit) instead of just name.

User avatar
petermad
Power Member
Power Member
Posts: 8066
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad » 2018-06-14, 20:56 UTC

Confirmed.

This is indeed new to TC 9.20
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.92b1 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36511
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-06-15, 10:00 UTC

Thanks, I will fix it. %m is also affected. %T and %t were affected in TC 9.12 and older too.
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 8066
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad » 2018-06-17, 19:38 UTC

%m is also affected.
%m doesn't seem to be affected in TC 9.20rc1 - here it gives just name as expected.

But %p also seems to be getting the path differently on FTP:

%P gives: /remote_dir/parent_dir(s)/current_dir/
%p gives: ftp://username@hostname/remote_dir/parent_dir(s)/current_dir/
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.92b1 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36511
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-06-18, 09:24 UTC

I remember doing this so users could pass the URL to the called program, so I will keep it and document it in the help. Not sure whether I should change %t - it may affect users who currently use that.
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 8066
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad » 2018-06-18, 10:03 UTC

Right now %t (and %T) gives:
0:/remote_dir/parent_dir(s)/current_dir/\
notice the backslash at the end

To match %p I think %t should give:
ftp://username@hostname/remote_dir/parent_dir(s)/current_dir/

And %T should be fixed to give:
/remote_dir/parent_dir(s)/current_dir/
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.92b1 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36511
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-06-18, 10:13 UTC

I have already fixed %T for the next version. But I'm not so sure about %t what it should return.
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 8066
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad » 2018-06-18, 10:23 UTC

But I'm not so sure about %t what it should return
Well, as I wrote: I think it should match %p and then document both in the help.
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.92b1 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36511
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-06-20, 18:28 UTC

This should be fixed in RC2, please try it!
Author of Total Commander
http://www.ghisler.com

User avatar
Gral
Power Member
Power Member
Posts: 665
Joined: 2005-01-26, 15:12 UTC

Post by *Gral » 2018-06-20, 20:14 UTC

Fixed.

User avatar
petermad
Power Member
Power Member
Posts: 8066
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad » 2018-06-20, 20:48 UTC

%M, %T and %t fixed in TC 9.20rc2 for FTP entries :-)

Only one little thing: For some reason %t on lokal harddisk uses uppercase drive letter where %T, %P and %p all uses lowercase drive letter...
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.92b1 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
Gral
Power Member
Power Member
Posts: 665
Joined: 2005-01-26, 15:12 UTC

Post by *Gral » 2018-06-20, 21:38 UTC

It seems that %T %P %p depends on "DrivesShowUpcase" setting, while %t is hardcoded.

User avatar
petermad
Power Member
Power Member
Posts: 8066
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad » 2018-06-20, 21:41 UTC

It seems that %T %P %p depends on "DrivesShowUpcase" setting, while %t is hardcoded.
Confirmed.

It would be nice if it was consistant.
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.92b1 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
Gral
Power Member
Power Member
Posts: 665
Joined: 2005-01-26, 15:12 UTC

Post by *Gral » 2018-06-20, 21:51 UTC

New bug report created - https://www.ghisler.ch/board/viewtopic.php?t=50166

(with quotes :)

Post Reply