This forum uses cookies. Click X button to hide this message. What is stored? / Privacy
Total Commander Forum Index Total Commander
Forum - Public Discussion and Support
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Saved searches load partially

 
Post new topic   Reply to topic    Total Commander Forum Index -> TC Fixed bugs Printable version
View previous topic :: View next topic  
Author Message
Gral
Power Member
Power Member


Joined: 26 Jan 2005
Posts: 601

PostPosted: Thu Jun 14, 2018 2:17 pm    Post subject: Saved searches load partially Reply with quote

TC 9.20 beta 5, beta 6 and RC 1 loads only about 35-36 first saved searches - depends on length - on Load/Save page of "Find Files" and "Show" - "Custom" dialog window (Ctrl+F12).
Betas 1-4 works correctly with exactly the same INIs.
Both 32 and 64 bits versions works the same way.
Windows 10 Home x64, Spring Creators 2018, Build 17134.112


Last edited by Gral on Thu Jun 14, 2018 3:07 pm; edited 1 time in total
Back to top
View user's profile Send private message
petermad
Power Member
Power Member


Joined: 05 Feb 2003
Posts: 7794
Location: Valsted, Denmark

PostPosted: Thu Jun 14, 2018 2:44 pm    Post subject: Reply with quote

I cannot confirm this. Tested with TC 9.20rc1 under Windows 7 and 10 (1803, 17124.81)

Maybe you got an erroneous entry in your [Searches] section
_________________
#524
Danish Total Commander Translator
TC 9.20rc1 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit. TC 2.91b3 on Android 6.0

Get Extended Total Commander Menus
Back to top
View user's profile Send private message Send e-mail Visit poster's website
Gral
Power Member
Power Member


Joined: 26 Jan 2005
Posts: 601

PostPosted: Thu Jun 14, 2018 2:53 pm    Post subject: Reply with quote

petermad wrote:
I cannot confirm this. Tested with TC 9.20rc1 under Windows 7 and 10 (1803, 17124.81)

Maybe you got an erroneous entry in your [Searches] section


I don't think so - as i wrote beta 4 and all earlier versions works correctly.
But i realized today - maybe new Windows build updated this morning, about 9.50, causes this?

More info - first post edited
Back to top
View user's profile Send private message
petermad
Power Member
Power Member


Joined: 05 Feb 2003
Posts: 7794
Location: Valsted, Denmark

PostPosted: Thu Jun 14, 2018 3:43 pm    Post subject: Reply with quote

I have now updated my Window 10 to build 17134.112 and I still cannot reproduce the problem with TC 9.20rc1 x64

I have 38 saved Searches.
The total [Searches] section takes up 6147 bytes.
The longest line in the section is 282 bytes long.
My wincmd.ini is encoded in ANSI, codepage 1252.
_________________
#524
Danish Total Commander Translator
TC 9.20rc1 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit. TC 2.91b3 on Android 6.0

Get Extended Total Commander Menus
Back to top
View user's profile Send private message Send e-mail Visit poster's website
Gral
Power Member
Power Member


Joined: 26 Jan 2005
Posts: 601

PostPosted: Thu Jun 14, 2018 3:50 pm    Post subject: Reply with quote

Indeed, it's issue with my config, but i still don't understand - why older versions works correctly?
Back to top
View user's profile Send private message
Gral
Power Member
Power Member


Joined: 26 Jan 2005
Posts: 601

PostPosted: Thu Jun 14, 2018 4:15 pm    Post subject: Reply with quote

Case reopen?
(I didn't notice your reply while i wrote mine)

My [Searches] section in redirected file is 25954 bytes long (102 searches), truncated to match loaded part - 6767 bytes, so?
Back to top
View user's profile Send private message
petermad
Power Member
Power Member


Joined: 05 Feb 2003
Posts: 7794
Location: Valsted, Denmark

PostPosted: Thu Jun 14, 2018 5:52 pm    Post subject: Reply with quote

After doubleing the size of my searches I can now confirm the bug.

In TC 9.20 b5, b6 and rc1 only 47 of my 75 searches are shown - equal to 7767 bytes.

This is tested under Window 7 - so the bug is not OS-related.

The tested wincmd.ini file is only 40459 bytes, so it can not be a problem with a too big ini file.

Quote:
truncated to match loaded part - 6767 bytes

Notice that the order of the searches in wincmd.ini is not necessarily the same as in the list shown in TC (the list in wincmd.ini is not alphabetically sorted).
_________________
#524
Danish Total Commander Translator
TC 9.20rc1 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit. TC 2.91b3 on Android 6.0

Get Extended Total Commander Menus
Back to top
View user's profile Send private message Send e-mail Visit poster's website
Gral
Power Member
Power Member


Joined: 26 Jan 2005
Posts: 601

PostPosted: Thu Jun 14, 2018 6:03 pm    Post subject: Reply with quote

I can confirm bug on Windows 7 too.

petermad wrote:
Notice that the order of the searches in wincmd.ini is not necessarily the same as in the list shown in TC (the list in wincmd.ini is not alphabetically sorted).


I know - but mine is sorted.

So, bug confirmed, thanks for cooperation.
Back to top
View user's profile Send private message
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 35752
Location: Switzerland

PostPosted: Fri Jun 15, 2018 3:59 am    Post subject: Reply with quote

I could repeat it too, thanks. It happens because TC 9.20 now supports Unicode names for searches when the ini file is stored as UTF-16 Unicode. The conversion from ANSI to Unicode for plain text ini files uses only a 4kByte buffer. I will change that to a dynamically allocated buffer when the Unicode buffer is larger too.
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
Gral
Power Member
Power Member


Joined: 26 Jan 2005
Posts: 601

PostPosted: Sat Jun 16, 2018 3:04 am    Post subject: Reply with quote

I think there is need it to write it explicit - until fix the bug, workaround is the conversion of the INI file to Unicode UTF-16 LE (UCS-2 Little Endian)
Back to top
View user's profile Send private message
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 35752
Location: Switzerland

PostPosted: Wed Jun 20, 2018 12:31 pm    Post subject: Reply with quote

This should be fixed in RC2, please test!
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
Gral
Power Member
Power Member


Joined: 26 Jan 2005
Posts: 601

PostPosted: Wed Jun 20, 2018 2:14 pm    Post subject: Reply with quote

Fixed.
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    Total Commander Forum Index -> TC Fixed bugs All times are GMT - 6 Hours
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Imprint/Impressum: This site is maintained by Ghisler Software GmbH
Privacy Policy | Datenschutzerklärung | Politique de Confidentialité

Using phpBB © phpBB Group